| Summary: | [24.12.0 Regression] Overlay icons have inconsistent sizes when zooming in and out | ||
|---|---|---|---|
| Product: | [Applications] dolphin | Reporter: | Luke Horwell <code> |
| Component: | general | Assignee: | Dolphin Bug Assignee <dolphin-bugs-null> |
| Status: | RESOLVED FIXED | ||
| Severity: | normal | CC: | dimitri.code, dolphin-bugs-null |
| Priority: | NOR | ||
| Version First Reported In: | 24.12.0 | ||
| Target Milestone: | --- | ||
| Platform: | Other | ||
| OS: | Linux | ||
| Latest Commit: | https://invent.kde.org/system/dolphin/-/commit/961e6270e4401a6c7512df3a2e3efd09a25df962 | Version Fixed/Implemented In: | |
| Sentry Crash Report: | |||
| Attachments: |
Changing view scale in Dolphin 24.12 (left) and Dolphin 24.08.3 (right)
Screenshot showing inconsistency on hidden files with Git plugin Video of just one of the zoom jump still inconsistant |
||
|
Description
Luke Horwell
2024-12-12 15:58:12 UTC
Just to note, it seems to only affect the right overlay icon (e.g. emblem-symbolic-link, emblem-readonly). The left overlay icon scales as expected like the previous version (e.g. version control status: vcs-normal, vcs-locally-modified-unstaged, etc). Created attachment 176786 [details]
Screenshot showing inconsistency on hidden files with Git plugin
Looks like the left icon is indeed affected. I was going to open a new report, but it seems too similar to this one.
Overlay icons added by the Git plugin are inconsistently sized between hidden and non-hidden files and folders in Dolphin 24.12.
STEPS TO REPRODUCE
1. Create a directory and run "git init" inside.
2. Create files and folders, with some hidden by prefixing a dot in the name.
3. Commit the changes, e.g. "git add ." and "git commit -m Test".
4. Show hidden files in the folder.
5. Observe the overlay VCS icon size.
Hidden files/folders have a smaller VCS icon then non-hidden files/folders.
I am updating the title with "when zooming in and out" for the bug to not be confused with Bug 498211 about inconsistency of overlay between files. Git commit 961e6270e4401a6c7512df3a2e3efd09a25df962 by Méven Car. Committed on 17/01/2025 at 10:07. Pushed by meven into branch 'master'. Refactor Overlay Handling Now all overlays icons in kitemviews are added in KStandardItemListWidget::updatePixmapCache. data[iconOverlays] now contains icon names. DolphinFileItemListWidget::refreshCache is the sole responsible of setting the overlays either coming from KFileItemModelRolesUpdater or KVersionControlPlugin. This garantees consistency in rendering. M +3 -7 src/kitemviews/kfileitemmodelrolesupdater.cpp M +1 -1 src/kitemviews/kfileitemmodelrolesupdater.h M +52 -36 src/kitemviews/kstandarditemlistwidget.cpp M +10 -4 src/kitemviews/kstandarditemlistwidget.h M +17 -2 src/panels/information/informationpanelcontent.cpp M +18 -17 src/views/dolphinfileitemlistwidget.cpp M +1 -1 src/views/dolphinfileitemlistwidget.h https://invent.kde.org/system/dolphin/-/commit/961e6270e4401a6c7512df3a2e3efd09a25df962 Created attachment 178642 [details]
Video of just one of the zoom jump still inconsistant
The commit fixed almost all inconsistency between zoom level except for 1 of the zoom jump.
(In reply to Méven from comment #4) For the last zoom jump remaining after the commit (see attachment), should I re-open the bug ? Or create a new one ? > For the last zoom jump remaining after the commit (see attachment), should I > re-open the bug ? Or create a new one ? I have published a new bug report, the bug 500624 which talk about the size behavior around the zoom threshold for thumbnail in general. As the new behavior has the same issue with overlays and the rest of the thumbnail, I am not so sure that the bug report we are in should be reopened. I let someone else do it if it should be reopened. |