Bug 495444

Summary:	[Desktop Bar] Dropped windows "glide" offscreen
Product:	[Plasma] kwin	Reporter:	Blazer Silving <breakingspell>
Component:	effects-overview	Assignee:	KWin default assignee <kwin-bugs-null>
Status:	REOPENED ---
Severity:	minor	CC:	nate, notmart
Priority:	NOR	Keywords:	regression
Version:	6.2.2
Target Milestone:	---
Platform:	Arch Linux
OS:	Linux
Latest Commit:	https://invent.kde.org/plasma/kwin/-/commit/48b965b5c6c99360b65d12397127db862542dbfc	Version Fixed In:	6.2.4
Sentry Crash Report:
Attachments:	Desktop bar behavior in 6.1.5 Desktop bar behavior in 6.2.0

Description Blazer Silving 2024-10-27 19:29:27 UTC

SUMMARY
Noticed a regression with the desktop bar as of 6.2, windows dragged into the desktop bar pop and glide when dragged to a target desktop. Can reproduce on X11 and Wayland with two linear desktops, recordings attached.

STEPS TO REPRODUCE
1. Sign into new session (X11/Wayland)
2. Engage Overview (Meta+W) and add a second Virtual Desktop in the Desktop Bar
3. Drag and drop a window to the second desktop using the bar.
4. Observe the window behavior, where it originates in the thumbnail and "glides" offscreen.

OBSERVED RESULT
Windows "glide" offscreen to their target desktop. 

EXPECTED RESULT
Windows should "sink into" or otherwise stay in the target thumbnail, not glide to the actual target itself. 

SOFTWARE/OS VERSIONS
KDE Plasma Version: 6.2.2
KDE Frameworks Version: 6.7.0
Qt Version: 6.8.0

ADDITIONAL INFORMATION

Looks like the work from https://invent.kde.org/plasma/kwin/-/commit/01d7ddff68e9e616bbcfca2bedce0741d57a3500 is the cause, not sure how I didn't notice this in testing earlier this month. The refactored ExpoLayout otherwise seems to behave as expected. 

I'm thinking the fix may lie in:
src/plugins/overview/qml/DesktopBar.qml
src/plugins/private/qml/WindowHeapDelegate.qml

Comment 1 Blazer Silving 2024-10-27 19:30:27 UTC

Created attachment 175283 [details]
Desktop bar behavior in 6.1.5

Comment 2 Blazer Silving 2024-10-27 19:30:51 UTC

Created attachment 175284 [details]
Desktop bar behavior in 6.2.0

Comment 3 Nate Graham 2024-10-28 01:46:50 UTC

Can reproduce.

Comment 4 Bug Janitor Service 2024-11-07 14:44:43 UTC

A possibly relevant merge request was started @ https://invent.kde.org/plasma/kwin/-/merge_requests/6747

Comment 5 Marco Martin 2024-11-07 16:23:44 UTC

Git commit 2e0b33eae4588a829e64495efbb27a25da311190 by Marco Martin.
Committed on 07/11/2024 at 16:04.
Pushed by mart into branch 'master'.

effects/overview: Don't make thumbnails fly off the screen

When dropping a thumbnail on another desktop, don't animate the
position, otherwise we see the window oddly flying off the screen
to go on its new position on the different desktop

M  +9    -0    src/plugins/private/qml/WindowHeapDelegate.qml

https://invent.kde.org/plasma/kwin/-/commit/2e0b33eae4588a829e64495efbb27a25da311190

Comment 6 Blazer Silving 2024-11-09 18:17:14 UTC

Confirmed fixed, thanks y'all!

Comment 7 Marco Martin 2024-11-15 16:48:16 UTC

Git commit 48b965b5c6c99360b65d12397127db862542dbfc by Marco Martin.
Committed on 15/11/2024 at 16:37.
Pushed by mart into branch 'Plasma/6.2'.

effects/overview: Don't make thumbnails fly off the screen

When dropping a thumbnail on another desktop, don't animate the
position, otherwise we see the window oddly flying off the screen
to go on its new position on the different desktop


(cherry picked from commit 2e0b33eae4588a829e64495efbb27a25da311190)

2e0b33ea effects/overview: Don't make thumbnails fly off the screen

Co-authored-by: Marco Martin <notmart@gmail.com>

M  +9    -0    src/plugins/private/qml/WindowHeapDelegate.qml

https://invent.kde.org/plasma/kwin/-/commit/48b965b5c6c99360b65d12397127db862542dbfc

Comment 8 Blazer Silving 2024-12-01 20:57:29 UTC

Following BUG 496646 and the corresponding fix: https://invent.kde.org/plasma/kwin/-/commit/c402845961fa10185d7c28a49a9b72e7581258f8

The Desktop Bar's behavior following the above fix has reverted to the state described in this issue. Re-opening this case to focus on the Desktop Bar by itself.