Bug 495256

Summary: A single-line SelectableLabel's implicitHeight is too tall now
Product: [Frameworks and Libraries] frameworks-kirigami Reporter: Nate Graham <nate>
Component: generalAssignee: kdelibs bugs <kdelibs-bugs-null>
Status: RESOLVED FIXED    
Severity: normal CC: akselmo, notmart
Priority: NOR Keywords: regression
Version First Reported In: Master   
Target Milestone: Not decided   
Platform: Other   
OS: Linux   
Latest Commit: Version Fixed/Implemented In:
Sentry Crash Report:
Attachments: Lines are too tall now

Description Nate Graham 2024-10-23 18:24:49 UTC
Created attachment 175155 [details]
Lines are too tall now

See attached screenshot for the effect in Info Center.
Comment 1 Bug Janitor Service 2024-10-23 19:13:25 UTC
A possibly relevant merge request was started @ https://invent.kde.org/frameworks/kirigami/-/merge_requests/1648
Comment 2 Nate Graham 2024-10-23 21:34:48 UTC
Git commit 9738ae7ab7d823630f7ea475673f9c8cc8c65dce by Nate Graham.
Committed on 23/10/2024 at 21:20.
Pushed by ngraham into branch 'master'.

SelectableLabel: override default padding values more completely

It was already setting padding to 0, but that doesn't override the
individual top/left/right/bottom properties. We need to do those too,
and also set them to undefined instead of 0 to make it easier for users
of the control to re-add padding if they want.

M  +6    -1    src/controls/SelectableLabel.qml

https://invent.kde.org/frameworks/kirigami/-/commit/9738ae7ab7d823630f7ea475673f9c8cc8c65dce