| Summary: | Inappropriate host name capitalization | ||
|---|---|---|---|
| Product: | [Applications] Smb4k | Reporter: | Pedro V <voidpointertonull+bugskdeorg> |
| Component: | general | Assignee: | Alexander Reinholdt <alexander.reinholdt> |
| Status: | REPORTED --- | ||
| Severity: | minor | ||
| Priority: | NOR | ||
| Version First Reported In: | unspecified | ||
| Target Milestone: | --- | ||
| Platform: | Other | ||
| OS: | Linux | ||
| Latest Commit: | Version Fixed/Implemented In: | ||
| Sentry Crash Report: | |||
The user-provided host name is converted to uppercase unconditionally almost everywhere, which is inappropriate for the following reasons: - It's usual to capitalize the NetBIOS name, but it doesn't seem to be mandatory. Searching for pictures of Windows mounted shares revealed plenty of examples of lowercase names, especially in cases of DNS names being used. - The user provided URL is allowed to contain an arbitrary host name which is preserved in a case sensitive manner in the bookmark file, which results in an odd combination of allowing custom names, but forcing an outdated tradition on the names. Considering this a bug instead of a wishlist item due to non-ancient Windows versions seemingly not forcing uppercase names (anymore?). Beware of potential breakage. If this ever gets dealt with, a new config entry (per mount?) should determine if the name is case sensitive ("new"), or should be still capitalized ("old") to make sure old bookmarked items still get the same path. This may be also somewhat obsoleted if the current prefix-based path approach gets replaced by something more flexible in the future, like a path pattern with variables, or custom paths per mounts. Names in the GUI still shouldn't be unconditionally capitalized though.