| Summary: | Jobs are not canceled when KNS dialog is closed, which can cause initiating apps to not exit | ||
|---|---|---|---|
| Product: | [Frameworks and Libraries] frameworks-knewstuff | Reporter: | Nate Graham <nate> |
| Component: | general | Assignee: | Dan Leinir Turthra Jensen <admin> |
| Status: | RESOLVED FIXED | ||
| Severity: | major | CC: | alexander.lohnau, kdelibs-bugs, sitter |
| Priority: | NOR | ||
| Version: | unspecified | ||
| Target Milestone: | --- | ||
| Platform: | Other | ||
| OS: | Linux | ||
| Latest Commit: | https://invent.kde.org/frameworks/knewstuff/-/commit/d31ed6cccc30091754501476e18fa3b2efe62903 | Version Fixed In: | 6.8 |
| Sentry Crash Report: | |||
|
Description
Nate Graham
2024-09-12 04:44:22 UTC
Curiously I cannot reproduce this with my hacked up knewstuff so I think I fixed this by accident somewhere already, just need to find the relevant diff. Definitely broken with stock master build though. Actually. Can you give this a go https://invent.kde.org/frameworks/knewstuff/-/merge_requests/333 Unfortunately that MR does not fix the issue for me. A thread is still open and blocking systemsettings from exiting. Ah! I have more diff on my system. Will test some more. I have a conceptual question meanwhile: what if installation takes more than a second or two? I see two UX-feasible options for how to handle if the user tries to close the window while a job is pending: - Show a warning dialog with the option to kill the job to close the window, or else keep it open until it finished - Allow closing the window and show a system notification with the progress of the job (Discover does this) Git commit 271c92e978b1a9637d043faff2fd3b15121864b1 by Harald Sitter. Committed on 14/10/2024 at 11:39. Pushed by sitter into branch 'master'. filecopyworker: try to gracefully quit the thread. then terminate it this should prevent scenarios where the thread gets destroyed on application exit and bringing down the application with it due to destruction of a running thread being qFatal. M +12 -1 src/core/jobs/filecopyworker.cpp https://invent.kde.org/frameworks/knewstuff/-/commit/271c92e978b1a9637d043faff2fd3b15121864b1 Git commit c7a457ea5ffe2c13b853a0230295ab36cefa609a by Harald Sitter. Committed on 14/10/2024 at 11:39. Pushed by sitter into branch 'master'. put qnetworkreplys in a self-aborting unique_ptr this should prevent issues where the reply keeps running for a potentially longer time than desired. when the worker is gone there is no need to run the reply any longer. M +19 -8 src/core/jobs/httpworker.cpp https://invent.kde.org/frameworks/knewstuff/-/commit/c7a457ea5ffe2c13b853a0230295ab36cefa609a Git commit 93667cb0fe8cfca5b1b85e957d3cd5324ca48fc0 by Harald Sitter. Committed on 14/10/2024 at 11:39. Pushed by sitter into branch 'master'. parent the xml loader's httpjob so it may be destroyed when the loader gets destroyed and not keep running for potentially more than a second (holding up app shutdown) M +1 -1 src/core/xmlloader.cpp https://invent.kde.org/frameworks/knewstuff/-/commit/93667cb0fe8cfca5b1b85e957d3cd5324ca48fc0 Git commit d31ed6cccc30091754501476e18fa3b2efe62903 by Harald Sitter. Committed on 14/10/2024 at 11:39. Pushed by sitter into branch 'master'. make sure the action's dialog closes because it is held by a loader it would ordinarily stick around which is problematic because it is a top level window and can hold up automatic application quitting on last-window-closed M +8 -0 src/qtquick/qml/Action.qml https://invent.kde.org/frameworks/knewstuff/-/commit/d31ed6cccc30091754501476e18fa3b2efe62903 |