| Summary: | Notifications with long URLs that wrap anyway unnecessarily expand in width | ||
|---|---|---|---|
| Product: | [Plasma] plasmashell | Reporter: | Nate Graham <nate> |
| Component: | Notifications | Assignee: | Plasma Bugs List <plasma-bugs-null> |
| Status: | RESOLVED FIXED | ||
| Severity: | minor | CC: | ahiemstra, justin, kde, notmart |
| Priority: | NOR | Keywords: | regression |
| Version First Reported In: | master | ||
| Target Milestone: | 1.0 | ||
| Platform: | Other | ||
| OS: | Linux | ||
| See Also: | https://bugs.kde.org/show_bug.cgi?id=492861 | ||
| Latest Commit: | https://invent.kde.org/plasma/plasma-workspace/-/commit/e7ea4203bafa9e057a50b54386f9604324d6ff55 | Version Fixed/Implemented In: | |
| Sentry Crash Report: | |||
| Attachments: | Wide boi popup | ||
|
Description
Nate Graham
2024-09-10 07:52:03 UTC
Can confirm on git master as well. To reproduce: notify-send "title" "https://bugs.kde.org/query.cgi?bug_severity=critical&bug_severity=grave&bug_severity=major&bug_severity=normal&bug_severity=minor&bug_severity=task&bug_status=UNCONFIRMED&columnlist=product%2Ccomponent%2Cassigned_to%2Cbug_status%2Cresolution%2Cshort_desc%2Cchangeddate%2Cbug_severity&product=plasmashell&query_format=advanced&known_name=Plasma%20TODO" I think the two related 492932 and https://bugs.kde.org/show_bug.cgi?id=492861 are from some qtquick layout quirks caused by https://bugreports.qt.io/browse/QTBUG-126196 that would force to set both the title and the main body of the notification to an hardcoded maximum width for the time being also this is exactly what https://invent.kde.org/plasma/plasma-workspace/-/merge_requests/4598 was set to do. it made popups stretchable to wider sizes, but we don't have fine grained control on text hints like "if that'a an url, you can elide it" so either it can become very wide, or it can't A possibly relevant merge request was started @ https://invent.kde.org/plasma/plasma-workspace/-/merge_requests/4705 Git commit e144c6e96e8e8b1ef4049f80a87e445ab8570b0d by Marco Martin. Committed on 19/09/2024 at 14:44. Pushed by mart into branch 'master'. Limit maximum popup width and stretch body label Add a maximum, kinda hardcoded popup maximum width to not make notifications so exceedingly large, keep headings expanding, while still wrapping Related: bug 492861 M +3 -2 applets/notifications/package/contents/ui/NotificationItem.qml https://invent.kde.org/plasma/plasma-workspace/-/commit/e144c6e96e8e8b1ef4049f80a87e445ab8570b0d Git commit e7ea4203bafa9e057a50b54386f9604324d6ff55 by Marco Martin. Committed on 20/09/2024 at 07:16. Pushed by mart into branch 'Plasma/6.2'. Limit maximum popup width and stretch body label Add a maximum, kinda hardcoded popup maximum width to not make notifications so exceedingly large, keep headings expanding, while still wrapping Related: bug 492861 (cherry picked from commit e144c6e96e8e8b1ef4049f80a87e445ab8570b0d) 7368b6f9 Limit maximum popup width and stretch body label d3813bdf different attempt Co-authored-by: Marco Martin <notmart@gmail.com> M +3 -2 applets/notifications/package/contents/ui/NotificationItem.qml https://invent.kde.org/plasma/plasma-workspace/-/commit/e7ea4203bafa9e057a50b54386f9604324d6ff55 |