Bug 492861

Summary: 2cdaa659dde3fc64b9af2d672844a08180d5a316 causes title of non-grouped notification to elide early in history
Product: [Plasma] plasmashell Reporter: Nate Graham <nate>
Component: NotificationsAssignee: Plasma Bugs List <plasma-bugs-null>
Status: RESOLVED FIXED    
Severity: normal CC: kde
Priority: NOR Keywords: regression
Version First Reported In: master   
Target Milestone: 1.0   
Platform: Other   
OS: Linux   
See Also: https://bugs.kde.org/show_bug.cgi?id=492932
Latest Commit: https://invent.kde.org/plasma/plasma-workspace/-/commit/e7ea4203bafa9e057a50b54386f9604324d6ff55 Version Fixed/Implemented In:
Sentry Crash Report:
Attachments: Title elided too early in history

Description Nate Graham 2024-09-09 06:31:08 UTC 
Created attachment 173469 [details]
Title elided too early in history

STEPS TO REPRODUCE
1. Have plasma-browser-integration installed
2. Open Notification widget and clear history, if it had any items in it
3. Visit https://conf.kde.org/event/6/contributions/200/attachments/117/147/goalswrapup.pdf in a PBI-using browser
4. After the download notification times out, open the Notifications widget


OBSERVED RESULT
The title of the notifications gets elided early, saying, "Downloaded (…"


EXPECTED RESULT
Full text shown


ADDITIONAL INFORMATION
If you download the same file again, a second notification will be generated and shown in the widget. With two visible, they enter "grouped notification" mode and the titles will not be elided anymore

To avoid having to repeatedly download files, this can also be tested in the following way:
1. System Settings > Notifications > Application Settings > Other applications > Check "Show in history"
2. Open Notification widget and clear history, if it had any items in it
3. In a terminal window, run `notify-send "I am a title, hear me roar. Maybe I will elide if you make me long enough." "Hi"`

This issue was introduced with 2cdaa659dde3fc64b9af2d672844a08180d5a316. However reverting it makes the title overflow rather than elide early, so clearly the problem is a bit deeper.
Comment 1 Nate Graham 2024-09-09 06:32:22 UTC 
(2cdaa659dde3fc64b9af2d672844a08180d5a316 in plasma-workspace)
Comment 2 Bug Janitor Service 2024-09-16 13:30:13 UTC 
A possibly relevant merge request was started @ https://invent.kde.org/plasma/plasma-workspace/-/merge_requests/4705
Comment 3 Marco Martin 2024-09-19 14:44:15 UTC 
Git commit e144c6e96e8e8b1ef4049f80a87e445ab8570b0d by Marco Martin.
Committed on 19/09/2024 at 14:44.
Pushed by mart into branch 'master'.

Limit maximum popup width and stretch body label

Add a maximum, kinda hardcoded popup maximum width to not
make notifications so exceedingly large, keep headings
expanding, while still wrapping
Related: bug 492932

M  +3    -2    applets/notifications/package/contents/ui/NotificationItem.qml

https://invent.kde.org/plasma/plasma-workspace/-/commit/e144c6e96e8e8b1ef4049f80a87e445ab8570b0d
Comment 4 Marco Martin 2024-09-20 07:39:22 UTC 
Git commit e7ea4203bafa9e057a50b54386f9604324d6ff55 by Marco Martin.
Committed on 20/09/2024 at 07:16.
Pushed by mart into branch 'Plasma/6.2'.

Limit maximum popup width and stretch body label

Add a maximum, kinda hardcoded popup maximum width to not
make notifications so exceedingly large, keep headings
expanding, while still wrapping
Related: bug 492932


(cherry picked from commit e144c6e96e8e8b1ef4049f80a87e445ab8570b0d)

7368b6f9 Limit maximum popup width and stretch body label
d3813bdf different attempt

Co-authored-by: Marco Martin <notmart@gmail.com>

M  +3    -2    applets/notifications/package/contents/ui/NotificationItem.qml

https://invent.kde.org/plasma/plasma-workspace/-/commit/e7ea4203bafa9e057a50b54386f9604324d6ff55