Summary: | Kirigami.Icon doesn't accept the value of Qt.resolvedUrl() as source anymore, breaking many icons | ||
---|---|---|---|
Product: | [Frameworks and Libraries] frameworks-kirigami | Reporter: | Robby Engelmann <robby.engelmann> |
Component: | general | Assignee: | kdelibs bugs <kdelibs-bugs> |
Status: | RESOLVED FIXED | ||
Severity: | normal | CC: | kde, me, nate, nicolas.fella, notmart, robby.engelmann |
Priority: | HI | Keywords: | regression |
Version: | Master | ||
Target Milestone: | 1.0 | ||
Platform: | openSUSE | ||
OS: | Linux | ||
Latest Commit: | https://invent.kde.org/frameworks/kirigami/-/commit/5cfb3bb97213e7e5b4234143ceb5be4865be37a9 | Version Fixed In: | |
Sentry Crash Report: | |||
Attachments: | screenshot exemplifying the issue |
Description
Robby Engelmann
2024-08-17 06:00:51 UTC
Please attach a screenshot that shows the issue. Also, does it happen in a new clean user account with no customizations? Created attachment 172783 [details]
screenshot exemplifying the issue
Tested, and yes here it is also happening with a new user, adding Fokus or Wunderground Weather --> only placeholder symbol is shown. Thanks. Focus and Wunderground weather are both 3rd-party widgets, so I'll have to see what icons they're using. Are the only two widgets affected, or are there any others too? In the case of Wunderground Weather, the code to set the icon is wrong, probably because `iconCode` isn't getting set properly. Fokus has a similar issue; it can't find `customIconSource`. Thus, these widgets are broken and need fixes from their authors. It is also with Chat-AI and the Vivid-SDDM-6 theme (here shutdown etc icons are only placeholders). Using the Vivid-Splash-6 lead to kwayland crash and blocked the login totally (went back to the login screen). It first appeared before roughly a week or so. Hope that helps. Aha! It's f673694e6f90efa0179a6f8322d4c44d544ff591 in Kirigami. Reverting that fixes it for Focus and Wunderground Weather, and I assume for all the other cases as well. The common thing those two widgets do is `source: Qt.resolvedUrl([some local path])` in Kirigami.Icon. Perhaps that broke. A possibly relevant merge request was started @ https://invent.kde.org/frameworks/kirigami/-/merge_requests/1610 Git commit 5cfb3bb97213e7e5b4234143ceb5be4865be37a9 by Nicolas Fella. Committed on 22/08/2024 at 20:27. Pushed by cullmann into branch 'master'. [icon] Only reload icon from theme if the theme has that icon Otherwise we try to reload icons from absolute paths or non-standard search paths, which won't work Related: bug 491854, bug 491848 M +1 -1 src/primitives/icon.cpp https://invent.kde.org/frameworks/kirigami/-/commit/5cfb3bb97213e7e5b4234143ceb5be4865be37a9 fixed here using yesterdays master snapshot. Great! |