Bug 491028

Summary: Emoji grid view doesn't have a visible highlight anymore
Product: [Plasma] plasmashell Reporter: Gio <comments.frugivore>
Component: Emoji SelectorAssignee: Plasma Bugs List <plasma-bugs>
Status: RESOLVED FIXED    
Severity: normal CC: akselmo, correo--correo+kde, kde, nate, vonruhne
Priority: NOR Keywords: accessibility, regression, usability
Version: 6.1.3   
Target Milestone: 1.0   
Platform: Fedora RPMs   
OS: Linux   
Latest Commit: https://invent.kde.org/plasma/plasma-desktop/-/commit/e28b89a7e76c414a602e06965b2ae5a414a748e4 Version Fixed In: 6.2.0
Sentry Crash Report:

Description Gio 2024-07-30 14:13:23 UTC 
***
Up to few versions ago it was possible to navigate through the emojis and select them using the keyboard arrows.

Now, it does not work. Only the TAB works, thus, with the keyboard is only possible to select the category.
***


Linux/KDE Plasma:  Fedora v40
(available in About System)
KDE Plasma Version:  6.1.3
KDE Frameworks Version: 6.4.0
Qt Version: 6.7.2
Comment 1 Nate Graham 2024-07-30 16:46:05 UTC 
Can confirm.
Comment 2 Oded Arbel 2024-08-13 08:36:23 UTC 
*** Bug 487250 has been marked as a duplicate of this bug. ***
Comment 3 Akseli Lahtinen 2024-08-26 08:14:35 UTC 
For me, the focus is there, but it's just not visualized by anything. Moving with arrow keys selects an emoji, and pressing enter copies one. But user can't see which one it is.
Comment 4 Bug Janitor Service 2024-08-26 08:16:07 UTC 
A possibly relevant merge request was started @ https://invent.kde.org/plasma/plasma-desktop/-/merge_requests/2471
Comment 5 Gio 2024-08-26 15:56:15 UTC 
(In reply to Akseli Lahtinen from comment #3)
> For me, the focus is there, but it's just not visualized by anything. Moving
> with arrow keys selects an emoji, and pressing enter copies one. But user
> can't see which one it is.

True that. For me too but didn't notice before. Good catch.
Comment 6 Moritz Bunkus 2024-08-27 13:01:47 UTC 
It's not entirely true. If I first use the search to narrow things down, then using the cursor keys only moves the cursor in the search bar. Hitting tab once or twice leaves me in "where the heck is my focus now!?" land.
Comment 7 Nate Graham 2024-08-27 15:11:43 UTC 
Git commit e28b89a7e76c414a602e06965b2ae5a414a748e4 by Nate Graham, on behalf of Akseli Lahtinen.
Committed on 27/08/2024 at 15:11.
Pushed by ngraham into branch 'master'.

emojier: Use ItemDelegate for emojiLabel highlight

The bug was not that the focus didn't work, it was that the focus was
not indicated properly.

Using ItemDelegate for emojiLabel lets us use the default highlighting
across all the delegates. We then turn the highlight on with
`GridView.isCurrentItem`.
FIXED-IN: 6.1.5

M  +12   -24   emojier/app/ui/CategoryPage.qml

https://invent.kde.org/plasma/plasma-desktop/-/commit/e28b89a7e76c414a602e06965b2ae5a414a748e4