Summary: | Excessive width when not using Inline Grouping | ||
---|---|---|---|
Product: | [Plasma] plasmashell | Reporter: | Kisaragi Hiu <mail> |
Component: | Task Manager and Icons-Only Task Manager widgets | Assignee: | Plasma Bugs List <plasma-bugs-null> |
Status: | RESOLVED FIXED | ||
Severity: | normal | CC: | nate, qydwhotmail |
Priority: | NOR | ||
Version First Reported In: | 6.1.0 | ||
Target Milestone: | 1.0 | ||
Platform: | Arch Linux | ||
OS: | Linux | ||
Latest Commit: | https://invent.kde.org/plasma/plasma-desktop/-/commit/e78d3a39bcf5e1bc5f6b166cd4a2d4200ffdb5d4 | Version Fixed In: | 6.2.0 |
Sentry Crash Report: | |||
Attachments: |
Excessive width by default (panel height 46px)
Under inline grouping mode, the width goes to a more sensible size |
Description
Kisaragi Hiu
2024-06-28 13:34:30 UTC
Created attachment 171132 [details]
Under inline grouping mode, the width goes to a more sensible size
Additional "additional info": The 1.6x was reduced from 1.8x in https://invent.kde.org/plasma/plasma-desktop/-/commit/f34cf61260ab02dfda4da0cb1368d853df306246, citing https://bugs.kde.org/show_bug.cgi?id=351425 and https://bugs.kde.org/show_bug.cgi?id=353337. The 1.8x was already there when the QML task manager was first added: https://invent.kde.org/unmaintained/kde-workspace/-/commit/6255b2b7b5717c9d7066a493b3efda8761a886da#36bbdfc2e487070cc0f9fc9cdd4fca276e290a93_0_89 I do not understand why Inline Grouping should have a different width. Inline Grouping, as far as I understand, just makes it so that windows of the same app stays side by side and get dragged together. Don't these shrink as more windows are opened? In your example, it on;t looks excessive because that Konsole window doesn't have a long window title. But that's not an assumption we can make. The entire point of the icons-and-text Task Manager is to show text; the more of it we elide, the less of an advantage it has over the IOTM for people who want to see text. Regardless, in progress with https://invent.kde.org/plasma/plasma-desktop/-/merge_requests/2351. Git commit e78d3a39bcf5e1bc5f6b166cd4a2d4200ffdb5d4 by Kisaragi Hiu. Committed on 10/07/2024 at 02:13. Pushed by moonlight into branch 'master'. applets/taskmanager: remove inline grouping width special case There is no indication that using inline grouping (grouping as multiple buttons, with "Combine as single button" turned off) would change anything about the width of tasks items, so it should not be tied together. The special cased max width is also too small, with eg. the label for the default page in System Settings already clipping. The special case was added as part of https://phabricator.kde.org/D1882 just to match the behavior of Netrunner's Expanding Icons Task Manager fork from back then, which the feature was a port of. FIXED-IN: 6.2.0 M +0 -4 applets/taskmanager/package/contents/ui/code/layoutmetrics.js https://invent.kde.org/plasma/plasma-desktop/-/commit/e78d3a39bcf5e1bc5f6b166cd4a2d4200ffdb5d4 |