Bug 489187

Summary: Layouts list is out of bounds on a Russia locale
Product: [Applications] systemsettings Reporter: Oleg <oleg>
Component: kcm_keyboardAssignee: Plasma Bugs List <plasma-bugs>
Status: RESOLVED FIXED    
Severity: normal CC: butirsky, evgeniyharchenko.dev, lolkek202k, natalie_clarius, nate
Priority: NOR Keywords: regression
Version: 6.1.0   
Target Milestone: ---   
Platform: Arch Linux   
OS: Linux   
Latest Commit: Version Fixed In: 6.2.0
Sentry Crash Report:
Attachments: Keyboard KCM with LANG=ru_RU.UTF-8
Keyboard KCM with LANG=en_US.UTF-8

Description Oleg 2024-06-25 16:30:18 UTC
Created attachment 170966 [details]
Keyboard KCM with LANG=ru_RU.UTF-8

SUMMARY
Layouts list in "Add" for keyboard kcm is out of bounds. I think it's because some of the entries are too long.

STEPS TO REPRODUCE
1. Run LANG=ru_RU.UTF-8 systemsettings (given you have Russian locale generated)
2. Go to keyboard KCM
3. Try to add a new layout

OBSERVED RESULT
Layouts list is out of bounds

EXPECTED RESULT
It shouldn't

SOFTWARE/OS VERSIONS
Operating System: Arch Linux 
KDE Plasma Version: 6.1.0
KDE Frameworks Version: 6.3.0
Qt Version: 6.7.2
Kernel Version: 6.9.6-3-cachyos (64-bit)
Graphics Platform: Wayland
Processors: 8 × Intel® Core™ i7-7700K CPU @ 4.20GHz
Memory: 15.6 ГиБ of RAM
Graphics Processor: AMD Radeon RX 6700 XT
Comment 1 Oleg 2024-06-25 16:30:44 UTC
Created attachment 170967 [details]
Keyboard KCM with LANG=en_US.UTF-8
Comment 2 Nate Graham 2024-06-26 00:22:40 UTC
Whoops! Can reproduce.
Comment 3 Nate Graham 2024-06-27 00:05:10 UTC
Should be fixed by https://invent.kde.org/plasma/plasma-desktop/-/merge_requests/2342.
Comment 4 cwo 2024-08-08 18:58:22 UTC
*** Bug 491442 has been marked as a duplicate of this bug. ***
Comment 5 Nate Graham 2024-08-16 14:34:01 UTC
Git commit 1ae88857457132553bebccec5cabdac206c477e9 by Nate Graham, on behalf of Evgeny Chesnokov.
Committed on 16/08/2024 at 14:33.
Pushed by ngraham into branch 'master'.

kcms/keyboard: Redesign it

* New style for user layouts
* Reorganize settings
* New navigation
* Update "Add Layout" dialog
Related: bug 488957
FIXED-IN: 6.2.0

M  +5    -3    kcms/keyboard/kcm_keyboard.cpp
M  +12   -0    kcms/keyboard/kcm_keyboard.h
D  +0    -120  kcms/keyboard/ui/Advanced.qml
D  +0    -258  kcms/keyboard/ui/Hardware.qml
A  +106  -0    kcms/keyboard/ui/KeyBindings.qml     [License: GPL(v2.0+)]
A  +87   -0    kcms/keyboard/ui/LayoutDelegate.qml     [License: GPL(v2.0+)]
M  +145  -64   kcms/keyboard/ui/LayoutDialog.qml
D  +0    -518  kcms/keyboard/ui/Layouts.qml
A  +233  -0    kcms/keyboard/ui/Switching.qml     [License: GPL(v2.0+)]
M  +399  -49   kcms/keyboard/ui/main.qml
M  +10   -63   kcms/keyboard/userlayoutmodel.cpp
M  +3    -7    kcms/keyboard/userlayoutmodel.h

https://invent.kde.org/plasma/plasma-desktop/-/commit/1ae88857457132553bebccec5cabdac206c477e9