| Summary: | Tags are added incorrectly with slash (/) through Information Panel (F11) Tags section | ||
|---|---|---|---|
| Product: | [Applications] dolphin | Reporter: | m1vri31c |
| Component: | general | Assignee: | Dolphin Bug Assignee <dolphin-bugs-null> |
| Status: | RESOLVED FIXED | ||
| Severity: | major | CC: | cody, goodaqua, jhaiduce, kde, kfm-devel, kodyvonbargen, player_005, postix, tagwerk19, traevenglaser |
| Priority: | NOR | ||
| Version First Reported In: | 24.08.0 | ||
| Target Milestone: | --- | ||
| Platform: | Other | ||
| OS: | Linux | ||
| See Also: | https://bugs.kde.org/show_bug.cgi?id=433990 | ||
| Latest Commit: | https://invent.kde.org/libraries/baloo-widgets/-/merge_requests/88 | Version Fixed In: | |
| Sentry Crash Report: | |||
| Attachments: |
Showcase
kedittagsdialog.cpp Baloo-widgets.patch |
||
|
Description
m1vri31c
2024-06-16 16:19:05 UTC
Sorry, I forgot the context menu add tags menu existed. This refers to the pop-up window accessed through the properties panel. Adding/editing tags works as intended through the context menu. *** Bug 492898 has been marked as a duplicate of this bug. *** To m1vri31c@duck.com First of all, thank you for reporting this bug before me. So i'll mark my 492903 bug as duplicate of yours. Easily reproduced on mine system. I'd like to describe it more detailed to resolve confusions: There are 2 methods of assigning the tag: through "Assign Tags" in Context menu and through Information Panel. Information Panel assigns tag with slash (/) like "/context" while "Assign Tags" does this without slash (/) so tag must be like "context". Tag itself can be watched if it is with with slash (/) or not through: 1. By holding mouse over tag name in "Tags:" section in Information Panel (F11) 2. Through "Tags" column 3. Through terminal for file through `getfattr -d <path-to-file>` # Reproduced bug under: Operating System: EndeavourOS KDE Plasma Version: 6.1.4 KDE Frameworks Version: 6.5.0 Qt Version: 6.7.2 Kernel Version: 6.10.7-arch1-1 (64-bit) Graphics Platform: X11 Vanilla Dolphin, vanilla Baloo, vanilla EndeavourOS. --- Also... I want to ask question to you: Can I modify yours summary from "Tags are added incorrectly through add/edit tags menu" to "Tags are added incorrectly with slash (/) through Information Panel (F11) Tags section" to eliminate confusions in title of bug? Created attachment 173532 [details]
Showcase
*** Bug 492903 has been marked as a duplicate of this bug. *** (In reply to reports_go_brrr from comment #3) > Also... I want to ask question to you: Can I modify yours summary from "Tags > are added incorrectly through add/edit tags menu" to "Tags are added > incorrectly with slash (/) through Information Panel (F11) Tags section" to > eliminate confusions in title of bug? I went a head and made the change, that is much clearer There's some bulletproofing needed with tags ... ... Also Bug 433990, Bug 437494, Bug 437501 *** Bug 491393 has been marked as a duplicate of this bug. *** Created attachment 174642 [details]
kedittagsdialog.cpp Baloo-widgets.patch
Patch I made fixed my problem. Implement it at latest git of Baloo-widgets.
*** This bug has been marked as a duplicate of bug 493862 *** Okay, I made a merge request which must fix this bug. Help me to approve it. https://invent.kde.org/libraries/baloo-widgets/-/merge_requests/80 *** Bug 497422 has been marked as a duplicate of this bug. *** A possibly relevant merge request was started @ https://invent.kde.org/libraries/baloo-widgets/-/merge_requests/86 A possibly relevant merge request was started @ https://invent.kde.org/libraries/baloo-widgets/-/merge_requests/87 A possibly relevant merge request was started @ https://invent.kde.org/libraries/baloo-widgets/-/merge_requests/88 Git commit 8b69de1110b20a24ef41842efd7d1bb634568de0 by Méven Car. Committed on 05/03/2025 at 12:29. Pushed by meven into branch 'master'. kedittagsdialog: Don't prepend slash to tags Related: bug 493862 M +1 -1 src/kedittagsdialog.cpp https://invent.kde.org/libraries/baloo-widgets/-/commit/8b69de1110b20a24ef41842efd7d1bb634568de0 I can see that this has reached Neon Unstable... If I add a tag from within the F11 info panel, it no longer gets a slash prepended. I can be nasty and try adding a tag with explicit slashes, such as "/mytag/". These slashes get removed. I can add a hierarchical tag such as parent/child and that gets added It is still the case that if there's an xattr tag with a prefixed slash (a "/badtag"), Dolphin includes it in the Places panel and fails when trying to open the tag folder. This can be considered a bit of a hangover, people could have edited tags and written them back with prepended slashes and get the "Could not enter folder tags:/badtag" failure. Bug 493862 is still there, a bit more bulletproofing would be nice... It is good to see this bug fixed though, it was hurting. Thanks. *** Bug 503614 has been marked as a duplicate of this bug. *** |