Bug 486316

Summary:	Some folder icons do not have symbolic 16px and 22px versions and stay colorful at those sizes
Product:	[Plasma] Breeze	Reporter:	Dimitri <dimitri.code>
Component:	Icons	Assignee:	visual-bugs-null
Status:	RESOLVED FIXED
Severity:	minor	CC:	4wy78uwh, kainz.a, m, nate
Priority:	NOR
Version First Reported In:	6.0.4
Target Milestone:	---
Platform:	unspecified
OS:	Linux
Latest Commit:	https://invent.kde.org/frameworks/breeze-icons/-/commit/e16423aa6332b4d49a2367b917eb4f70964e364f	Version Fixed/Implemented In:	6.2
Sentry Crash Report:
Attachments:	Video showing folder icons not switching to symbolic on small sizes Folder with folder icons with no symbolic version

Description Dimitri 2024-04-29 21:06:28 UTC

SUMMARY
They are some folder icon without symbolic versions. If we get on really small sizes, every folder icons switch to their symbolic versions except those icons which doesn't have symbolic version and stay with folder looks.
This is the case for :
- folder-decrypted
- folder-encrypted
- library-music


STEPS TO REPRODUCE
1. Open a folder with multiple sub-folders
2. Put an affected folder-icon on one of the folder (right-clic > properties > clic on icon)
3. Switch to the third view (the detailed list view) and zoom in and out to see other folder changing between folder and symbolic
4. See that the affected icon does not switch as they should.

OBSERVED RESULT
Some icon does not switch as they should (see attachment).

EXPECTED RESULT
Every icon should switch to their symbolic version on really small sizes (for visibility and coherency).
Symbolic version of those folder should exist for that to happen.


SOFTWARE/OS VERSIONS
Operating System: KDE neon 6.0
KDE Plasma Version: 6.0.4
KDE Frameworks Version: 6.1.0
Qt Version: 6.7.0
Kernel Version: 6.5.0-28-generic (64-bit)
Graphics Platform: Wayland


ADDITIONAL INFORMATION
There is a bug which is the inverse of this one : icons with no folder versions, or more precisely with folder versions which are duplicates of symbolic versions.

Comment 1 Dimitri 2024-04-29 21:10:20 UTC

Created attachment 169016 [details]
Video showing folder icons not switching to symbolic on small sizes

Those are all folder icons without symbolic version that I have found, and I put some folder icons with symbolic version as example of how it should works.

Comment 2 Dimitri 2024-04-29 21:12:39 UTC

I thought that folder staying with folder looks on smallest size was an oversight in fixing bug 478016 but it was another bug.

Comment 3 Dimitri 2024-04-29 21:18:03 UTC

Created attachment 169017 [details]
Folder with folder icons with no symbolic version

The folder used for the example, with all the folder icons not having symbolic version I have found.
The folder needs to be unzipped for icons to show.

Comment 4 Nate Graham 2024-04-29 21:23:59 UTC

Can confirm. I'll fix it.

Comment 5 Dimitri 2024-04-29 21:56:09 UTC

The inverse case where folder icon always show symbolic versions is the bug 486318.

Comment 6 Dimitri 2024-04-29 21:59:16 UTC

(In reply to Nate Graham from comment #4)
> Can confirm. I'll fix it.
Thanks 👍

Comment 7 Nate Graham 2024-04-29 22:01:23 UTC

Git commit e16423aa6332b4d49a2367b917eb4f70964e364f by Nate Graham.
Committed on 29/04/2024 at 21:58.
Pushed by ngraham into branch 'master'.

Add 16 and 22px symbolic versions of some Places icons that were missing

Mostly just symlinks, but I did create new folder-edit-sign-decrypted
icons based on the "encrypted" versions.
FIXED-IN: 6.2

A  +1    -0    icons/actions/16/folder-edit-sign-decrypted-symbolic.svg
A  +12   -0    icons/actions/16/folder-edit-sign-decrypted.svg
A  +1    -0    icons/actions/22/folder-edit-sign-decrypted-symbolic.svg
A  +15   -0    icons/actions/22/folder-edit-sign-decrypted.svg
A  +1    -0    icons/places/16/folder-decrypted-symbolic.svg
A  +1    -0    icons/places/16/folder-decrypted.svg
A  +1    -0    icons/places/16/folder-encrypted-symbolic.svg
A  +1    -0    icons/places/16/folder-encrypted.svg
A  +1    -0    icons/places/22/folder-decrypted-symbolic.svg
A  +1    -0    icons/places/22/folder-decrypted.svg
A  +1    -0    icons/places/22/folder-encrypted-symbolic.svg
A  +1    -0    icons/places/22/folder-encrypted.svg
A  +1    -0    icons/places/22/library-music-symbolic.svg
A  +1    -0    icons/places/22/library-music.svg

https://invent.kde.org/frameworks/breeze-icons/-/commit/e16423aa6332b4d49a2367b917eb4f70964e364f

Comment 8 Dimitri 2024-04-29 22:04:20 UTC

(In reply to Nate Graham from comment #7)
> Git commit e16423aa6332b4d49a2367b917eb4f70964e364f by Nate Graham.
> Committed on 29/04/2024 at 21:58.
> Pushed by ngraham into branch 'master'.
> 
> Add 16 and 22px symbolic versions of some Places icons that were missing
> 
> Mostly just symlinks, but I did create new folder-edit-sign-decrypted
> icons based on the "encrypted" versions.
> FIXED-IN: 6.2
> [...]
> https://invent.kde.org/frameworks/breeze-icons/-/commit/
> e16423aa6332b4d49a2367b917eb4f70964e364f
OMG, it was fast !
You probably was already on it.

Comment 9 Nate Graham 2024-04-29 22:07:21 UTC

Nah, it was just easy to fix. :)