| Summary: | Next and Back arrows are wrong for RTL language | ||
|---|---|---|---|
| Product: | [Applications] Welcome Center | Reporter: | Zayed Al-Saidi <zayed.alsaidi> |
| Component: | general | Assignee: | Plasma Bugs List <plasma-bugs-null> |
| Status: | RESOLVED FIXED | ||
| Severity: | normal | CC: | nate |
| Priority: | NOR | Keywords: | rtl |
| Version First Reported In: | unspecified | ||
| Target Milestone: | --- | ||
| Platform: | Other | ||
| OS: | Linux | ||
| Latest Commit: | https://invent.kde.org/plasma/plasma-welcome/-/commit/02313ebd3f26d43f31c9721ed0486e4b846a4da0 | Version Fixed/Implemented In: | 6.0.5 |
| Sentry Crash Report: | |||
| Attachments: |
Current status as of 20-April-2024
the correct way for RtL languages |
||
Created attachment 168759 [details]
the correct way for RtL languages
Can confirm. How embarrassing; this is basic RTL language stuff. Will fix ASAP. A possibly relevant merge request was started @ https://invent.kde.org/plasma/plasma-welcome/-/merge_requests/154 Git commit 66227074420ca9f37174f5df18ac0dd97d709660 by Nate Graham. Committed on 21/04/2024 at 19:24. Pushed by olib into branch 'master'. Fix RTL footer buttons and navigation These are custom UI elements so we have to handle RTL languages ourselves. Previously we weren't; now we are. FIXED-IN: 6.0.5 M +20 -4 src/qml/footers/FooterDefault.qml M +1 -1 src/qml/footers/FooterUpdate.qml https://invent.kde.org/plasma/plasma-welcome/-/commit/66227074420ca9f37174f5df18ac0dd97d709660 Git commit 02313ebd3f26d43f31c9721ed0486e4b846a4da0 by Oliver Beard, on behalf of Nate Graham. Committed on 21/04/2024 at 20:53. Pushed by olib into branch 'Plasma/6.0'. Fix RTL footer buttons and navigation These are custom UI elements so we have to handle RTL languages ourselves. Previously we weren't; now we are. FIXED-IN: 6.0.5 (cherry picked from commit 66227074420ca9f37174f5df18ac0dd97d709660) M +20 -4 src/contents/ui/footers/FooterDefault.qml M +1 -1 src/contents/ui/footers/FooterUpdate.qml https://invent.kde.org/plasma/plasma-welcome/-/commit/02313ebd3f26d43f31c9721ed0486e4b846a4da0 |
Created attachment 168758 [details] Current status as of 20-April-2024 The next arrow and the back arrow are wrong for RTL languages. They should be mirrored. Please refer to the screenshot for the current status. I made a mockup of the correct way for RTL language in the second image. I'm using neon unstable git20240420