Bug 484665

Summary: crash on file browse
Product: [Applications] Elisa Reporter: Germano Massullo <germano.massullo>
Component: generalAssignee: Matthieu Gallien <matthieu_gallien>
Status: RESOLVED DUPLICATE    
Severity: crash CC: elvis.angelaccio, jackhill3103
Priority: NOR    
Version: 24.02.0   
Target Milestone: ---   
Platform: Other   
OS: Linux   
Latest Commit: Version Fixed In:
Sentry Crash Report:
Attachments: GDB

Description Germano Massullo 2024-03-28 13:55:07 UTC
Created attachment 167889 [details]
GDB

clicking on File on left Elisa column, triggers an Elisa crash. I attached GDB trace
Comment 1 Jack Hill 2024-04-02 11:37:02 UTC
I cannot reproduce this. What path do you have configured as the initial location for files view?
Comment 2 Germano Massullo 2024-04-02 12:40:13 UTC
(In reply to Jack Hill from comment #1)
> I cannot reproduce this. What path do you have configured as the initial
> location for files view?

/home/user/Music, which is empty
Comment 3 Bug Janitor Service 2024-05-14 12:25:54 UTC
A possibly relevant merge request was started @ https://invent.kde.org/multimedia/elisa/-/merge_requests/579
Comment 4 Jack Hill 2024-05-14 12:37:06 UTC
The crash should be fixed by the above merge request. Are you sure the crash happens when you click on the files tab? I cannot reproduce the crash when clicking on the files tab, but I can reproduce it when clicking the Enqueue button when the files tab is empty.
Comment 5 Bug Janitor Service 2024-05-16 13:50:28 UTC
A possibly relevant merge request was started @ https://invent.kde.org/multimedia/elisa/-/merge_requests/580
Comment 6 Jack Hill 2024-05-17 12:27:56 UTC

*** This bug has been marked as a duplicate of bug 441525 ***
Comment 7 Nate Graham 2024-06-30 17:04:19 UTC
Git commit fdd903291bc8e14aa3ac92f6d6afea67f316a44e by Nate Graham, on behalf of Jack Hill.
Committed on 30/06/2024 at 16:39.
Pushed by ngraham into branch 'master'.

Don't allow enqueueing all items in a view if the view is empty

Prevents the user from triggering a crash when enqueueing in an empty
Files view.

Test-plan:
- Set Elisa to index an empty directory, go into albums view, try to
  enqueue all items
- Use the Files view to navigate into an empty directory, try to enqueue
  all items

Before: crash when enqueuing from files, nothing happens when enqueuing
from albums view

Now: buttons to enqueue are disabled
Related: bug 484972

M  +1    -0    src/qml/AbstractDataView.qml
M  +3    -0    src/qml/NavigationActionBar.qml

https://invent.kde.org/multimedia/elisa/-/commit/fdd903291bc8e14aa3ac92f6d6afea67f316a44e