| Summary: | Activating a panel applet without any expanded view (like Minimize All or Show Desktop) breaks Autohide and Dodge Windows | ||
|---|---|---|---|
| Product: | [Plasma] plasmashell | Reporter: | Bharadwaj Raju <bharadwaj.raju777> |
| Component: | Panel | Assignee: | Niccolò Venerandi <niccolo> |
| Status: | RESOLVED FIXED | ||
| Severity: | normal | CC: | nate, niccolo.venerandi |
| Priority: | HI | Keywords: | regression |
| Version: | master | ||
| Target Milestone: | 1.0 | ||
| Platform: | Other | ||
| OS: | Linux | ||
| Latest Commit: | https://invent.kde.org/plasma/libplasma/-/commit/abad7a55865f8ad2e936b34b33ffa5c2fe7d5598 | Version Fixed In: | 6.0.3 |
| Sentry Crash Report: | |||
|
Description
Bharadwaj Raju
2024-03-18 20:41:00 UTC
A possibly relevant merge request was started @ https://invent.kde.org/plasma/libplasma/-/merge_requests/1082 Git commit 6794ae6ab7c2c50f5ac57d7f32f5db1f7347201c by Nate Graham, on behalf of Niccolò Venerandi. Committed on 25/03/2024 at 19:05. Pushed by ngraham into branch 'master'. Do not activate containment when one of its applet is activated Reasoning is that some applets use "activated" when they would to trigger their action, e.g. the show desktop applet. If the containment (here, the panel) also gets activated as a result, it will get mouse input and a blue line will appear. Previously this was avoided by some hacky code that (a) apparently was not working for some people and (b) broke auto-hide and dodge windows after clicking on "Minimize all". This will also allow us to delete the hack in plasma-desktop. Related: bug 479084 FIXED-IN: 6.0.3 M +0 -4 src/plasma/containment.cpp https://invent.kde.org/plasma/libplasma/-/commit/6794ae6ab7c2c50f5ac57d7f32f5db1f7347201c Git commit 6203530a48a46e276d8e59452d23861118c1e362 by Nate Graham, on behalf of Niccolò Venerandi. Committed on 25/03/2024 at 19:06. Pushed by ngraham into branch 'master'. Revert "Panel: Don't take keyboard focus when one of its widgets is activated" This reverts commit 5909ac488df5fa469174387be4bb1ffe23578d0a. This is a companion to https://invent.kde.org/plasma/libplasma/-/merge_requests/1082, which removes need for this hack Related: bug 479084 M +1 -4 desktoppackage/contents/views/Panel.qml https://invent.kde.org/plasma/plasma-desktop/-/commit/6203530a48a46e276d8e59452d23861118c1e362 A possibly relevant merge request was started @ https://invent.kde.org/plasma/plasma-desktop/-/merge_requests/2143 Git commit e53fd6b066d569ae8247e5565c51560ace7af078 by Nate Graham, on behalf of Niccolò Venerandi. Committed on 25/03/2024 at 19:06. Pushed by ngraham into branch 'Plasma/6.0'. Revert "Panel: Don't take keyboard focus when one of its widgets is activated" This reverts commit 5909ac488df5fa469174387be4bb1ffe23578d0a. This is a companion to https://invent.kde.org/plasma/libplasma/-/merge_requests/1082, which removes need for this hack Related: bug 479084 (cherry picked from commit 6203530a48a46e276d8e59452d23861118c1e362) c2994876 Revert "Panel: Don't take keyboard focus when one of its widgets is activated" M +1 -4 desktoppackage/contents/views/Panel.qml https://invent.kde.org/plasma/plasma-desktop/-/commit/e53fd6b066d569ae8247e5565c51560ace7af078 Git commit abad7a55865f8ad2e936b34b33ffa5c2fe7d5598 by Nate Graham, on behalf of Niccolò Venerandi. Committed on 25/03/2024 at 19:10. Pushed by ngraham into branch 'Plasma/6.0'. Do not activate containment when one of its applet is activated Reasoning is that some applets use "activated" when they would to trigger their action, e.g. the show desktop applet. If the containment (here, the panel) also gets activated as a result, it will get mouse input and a blue line will appear. Previously this was avoided by some hacky code that (a) apparently was not working for some people and (b) broke auto-hide and dodge windows after clicking on "Minimize all". This will also allow us to delete the hack in plasma-desktop. Related: bug 479084 FIXED-IN: 6.0.3 (cherry picked from commit 6794ae6ab7c2c50f5ac57d7f32f5db1f7347201c) M +0 -1 src/plasma/containment.cpp https://invent.kde.org/plasma/libplasma/-/commit/abad7a55865f8ad2e936b34b33ffa5c2fe7d5598 |