Bug 482612

Summary: Menu icon too large with vertical taskbar
Product: [Plasma] plasmashell Reporter: Ben <ben-public>
Component: Application Menu (Kicker)Assignee: Plasma Bugs List <plasma-bugs>
Status: RESOLVED FIXED    
Severity: normal CC: 4wy78uwh, andy, eugene.savitsky, nate
Priority: NOR Keywords: qt6
Version: master   
Target Milestone: 1.0   
Platform: Arch Linux   
OS: Linux   
See Also: https://bugs.kde.org/show_bug.cgi?id=467004
https://bugs.kde.org/show_bug.cgi?id=486420
Latest Commit: https://invent.kde.org/plasma/plasma-desktop/-/commit/fe78a1d0d55dfbabcece706e8c2d2fc0d6ac885c Version Fixed In: 6.0.5
Sentry Crash Report:
Attachments: Screenshot of taskbar with very large menu icon
Screenshot of taskbar with correctly-sized menu icon (KDE 5)

Description Ben 2024-03-06 23:27:34 UTC 
Created attachment 166524 [details]
Screenshot of taskbar with very large menu icon

SUMMARY
***
NOTE: If you are reporting a crash, please try to attach a backtrace with debug symbols.
See https://community.kde.org/Guidelines_and_HOWTOs/Debugging/How_to_create_useful_crash_reports
***


STEPS TO REPRODUCE
1. Set KDE taskbar to be vertical (left or right side) and expand the width (mine is around 250 pixels)
2. If application menu is added, the icon takes the full width AND keeps the 1:1 aspect ratio (making it very tall)

OBSERVED RESULT
Very large taskbar icon (see attached image)

EXPECTED RESULT
In KDE 5, the icon would take the full width, but not keep the same aspect ratio (the menu "button" took the entire width, but the icon had blank space to left and right preventing it from becoming this large)

SOFTWARE/OS VERSIONS
Linux/KDE Plasma: Arch Linux
(available in About System)
KDE Plasma Version: 6.0.1
KDE Frameworks Version: 6.0.0
Qt Version: 6.6.2

ADDITIONAL INFORMATION
Comment 1 Ben 2024-03-06 23:31:04 UTC 
I missed the "summary" section.  The problem is simply that the menu icon is too large with a wide vertical taskbar (as shown in the attached screenshot).  This wasn't a problem in KDE 5, but after the update to 6, the icon is very large.
Comment 2 Ben 2024-03-07 03:31:16 UTC 
Created attachment 166534 [details]
Screenshot of taskbar with correctly-sized menu icon (KDE 5)

I realized my desktop is still on KDE 5, so I've attached a screenshot of what the menu icon should look like.
Comment 3 Nate Graham 2024-03-07 19:15:34 UTC 

*** This bug has been marked as a duplicate of bug 467004 ***
Comment 4 Nate Graham 2024-05-01 20:41:11 UTC 
Un-duping as this requires a separate fix. Basically the same code change that fixed Bug 467004, but applied to Kicker.
Comment 5 Nate Graham 2024-05-01 20:41:22 UTC 
*** Bug 477813 has been marked as a duplicate of this bug. ***
Comment 6 Bug Janitor Service 2024-05-01 21:03:08 UTC 
A possibly relevant merge request was started @ https://invent.kde.org/plasma/plasma-desktop/-/merge_requests/2234
Comment 7 Nate Graham 2024-05-02 13:32:46 UTC 
Git commit c06fe1b26bc88405eb490096e4cbd12148e68457 by Nate Graham.
Committed on 02/05/2024 at 13:26.
Pushed by ngraham into branch 'master'.

applets/kicker: cap maximum icon size

Same principle as what was done in
https://invent.kde.org/plasma/plasma-desktop/-/merge_requests/2231.

For reasoning and longer-term plan, see
https://bugs.kde.org/show_bug.cgi?id=467004#c18
FIXED-IN: 6.0.5

M  +6    -4    applets/kicker/package/contents/ui/CompactRepresentation.qml

https://invent.kde.org/plasma/plasma-desktop/-/commit/c06fe1b26bc88405eb490096e4cbd12148e68457
Comment 8 Nate Graham 2024-05-02 13:51:48 UTC 
Git commit fe78a1d0d55dfbabcece706e8c2d2fc0d6ac885c by Nate Graham.
Committed on 02/05/2024 at 13:40.
Pushed by ngraham into branch 'Plasma/6.0'.

applets/kicker: cap maximum icon size

Same principle as what was done in
https://invent.kde.org/plasma/plasma-desktop/-/merge_requests/2231.

For reasoning and longer-term plan, see
https://bugs.kde.org/show_bug.cgi?id=467004#c18
FIXED-IN: 6.0.5


(cherry picked from commit c06fe1b26bc88405eb490096e4cbd12148e68457)

M  +6    -4    applets/kicker/package/contents/ui/CompactRepresentation.qml

https://invent.kde.org/plasma/plasma-desktop/-/commit/fe78a1d0d55dfbabcece706e8c2d2fc0d6ac885c