Summary: | When using a non-random slideshow ordering, remember the last-seen wallpaper the next time the slideshow plays | ||
---|---|---|---|
Product: | [Plasma] plasmashell | Reporter: | Ali <fakhamati> |
Component: | Image Wallpaper | Assignee: | Plasma Bugs List <plasma-bugs> |
Status: | RESOLVED FIXED | ||
Severity: | wishlist | CC: | gtx.swift, me, nate, notmart, qydwhotmail |
Priority: | NOR | Keywords: | qt6, regression |
Version: | 6.0.1 | ||
Target Milestone: | 1.0 | ||
Platform: | Neon | ||
OS: | Linux | ||
Latest Commit: | https://invent.kde.org/plasma/plasma-workspace/-/commit/d3b3c5384d688c0ba96017775d7e4909da033251 | Version Fixed In: | 6.0.2 |
Description
Ali
2024-03-06 13:49:04 UTC
I gather you set the order to something other than "Random"? (In reply to Nate Graham from comment #1) > I gather you set the order to something other than "Random"? No, Order is A to Z Thanks. It should already, but on plasmashell shutdown the config is not saved. (In reply to Fushan Wen from comment #4) > It should already, but on plasmashell shutdown the config is not saved. That sounds like it could be the cause of several other bug reports: Bug 481085, Bug 482469, Bug 482090, Bug 481113,and Bug 482773. Also this bug report is about preserving the last-seen image for the slideshow on the lock screen specifically, where a plasmashell restart isn't necessarily going to happen. I can partially fix it, but in Qt6 objects in QML do not go through their dtors on application quit. A possibly relevant merge request was started @ https://invent.kde.org/plasma/plasma-workspace/-/merge_requests/4035 Connections { enabled: root.pluginName === "org.kde.slideshow" target: Qt.application function onAboutToQuit() { root.configuration.writeConfig(); // Save the last position } } This connection will save the config on application quit. The connection has to be in QML otherwise it's not called. Git commit e770ec489aedc4361583a972bc8cd4d2950dd698 by Fushan Wen. Committed on 11/03/2024 at 01:02. Pushed by fusionfuture into branch 'master'. wallpapers/image: save the last position for slideshow on exit The connection to aboutToQuit has to been in QML because on application quit QQuickItem doesn't go through its dtor. FIXED-IN: 6.0.2 M +14 -0 wallpapers/image/imagepackage/contents/ui/main.qml https://invent.kde.org/plasma/plasma-workspace/-/commit/e770ec489aedc4361583a972bc8cd4d2950dd698 Git commit d3b3c5384d688c0ba96017775d7e4909da033251 by Fushan Wen. Committed on 11/03/2024 at 01:02. Pushed by fusionfuture into branch 'Plasma/6.0'. wallpapers/image: save the last position for slideshow on exit The connection to aboutToQuit has to been in QML because on application quit QQuickItem doesn't go through its dtor. FIXED-IN: 6.0.2 (cherry picked from commit e770ec489aedc4361583a972bc8cd4d2950dd698) a5383221 wallpapers/image: save the last position for slideshow on exit M +14 -0 wallpapers/image/imagepackage/contents/ui/main.qml https://invent.kde.org/plasma/plasma-workspace/-/commit/d3b3c5384d688c0ba96017775d7e4909da033251 |