| Summary: | Overlapping widgets with Activities widget on panel | ||
|---|---|---|---|
| Product: | [Plasma] plasmashell | Reporter: | Antonio Rojas <arojas> |
| Component: | Activity Switcher sidebar | Assignee: | Plasma Bugs List <plasma-bugs> |
| Status: | RESOLVED FIXED | ||
| Severity: | normal | CC: | friedman.edo, ivan.cukic, julien.dlq, kde, kishore96, me, nate, nicolas.fella, notmart, oded |
| Priority: | NOR | Keywords: | regression |
| Version: | 6.0.0 | ||
| Target Milestone: | 1.0 | ||
| Platform: | Other | ||
| OS: | Linux | ||
| See Also: | https://bugs.kde.org/show_bug.cgi?id=477317 | ||
| Latest Commit: | https://invent.kde.org/plasma/plasma-desktop/-/commit/449be743eb6eb6decb9927442c11238fb0a05ab2 | Version Fixed In: | 6.0.5 |
| Sentry Crash Report: | |||
| Attachments: | Screenshot | ||
I think this may be a few separate bugs in individual applets, or else one in the Panel. But I haven't investigated it yet so I'm not sure of that. (In reply to Antonio Rojas from comment #0) > Bisected to 6da5023bc90d81a182f71411e18721c5f425a807 I find it very strange the culprit would really be in this comment in kirigami, as all it does is to actually hardcode some spacings to a fixed pixel amount, also kirigami isn't used that much in plasma shell, i suspect is something coming out from the same root cause of https://bugs.kde.org/show_bug.cgi?id=477317 (even tough a different effect as is items with wrong layout rather than window with wrong size) Very very likely, yes. *** This bug has been marked as a duplicate of bug 477317 *** FWIW, after removing the showActivityManager plasmoid from the panel I can no longer reproduce the issue. So it seems to be an issue with that specific plasmoid after the kirigami size change (and unrelated to the older bug 477317) Is that a 3rd-party widget? (In reply to Nate Graham from comment #5) > Is that a 3rd-party widget? No https://invent.kde.org/plasma/plasma-desktop/-/tree/master/applets/showActivityManager Ok, thanks. I haven't been able to make it happen after trying to replicate that setup. After some investigation in Bug 477317, we found that there were some sizing issues in Qt which have been fixed for Qt 6.7.1, and we also pushed a change to master. Antonio, would you be able to test whether the combination of these changes fixes the issue for you? Thank super be super. Thanks a lot! (In reply to Nate Graham from comment #8) > After some investigation in Bug 477317, we found that there were some sizing > issues in Qt which have been fixed for Qt 6.7.1, and we also pushed a change > to master. Antonio, would you be able to test whether the combination of > these changes fixes the issue for you? Thank super be super. Thanks a lot! Sure, can you point me to the Qt fixes I need to test? From what I can tell, 5539bc8ce3ff1d2e5f6e78be4185e0cac4615218 in QtWayland may be enough, but if that doesn't fix it I'll see if I can track down any more fixed that might also be needed. Thanks a lot for testing! No, these commits don't fix the issue unfortunately. Ah dang it. Thanks anyway, I appreciate you spending the effort on it. I don't know if this is a bad practice or something, but removing the explicit height and width on the icon in the showActivityManager applet seems to fix it for me. I suspect it's due to the icon's dimensions being dependent on its parent's dimensions, which fills the root, whose preferredWidth is dependent on the the icon's width. Would you be interested in submitting a merge request to fix it? Sounds like the code there is pretty old and in need of some maintenance to fix issues that got worse in Qt6. A possibly relevant merge request was started @ https://invent.kde.org/plasma/plasma-desktop/-/merge_requests/2242 Git commit 449be743eb6eb6decb9927442c11238fb0a05ab2 by Nate Graham, on behalf of Edo Friedman. Committed on 09/05/2024 at 19:57. Pushed by ngraham into branch 'master'. applets/showActivityManager: Fix and improve layout Fixes an issue where the showActivityManager applet was too small and caused some applets on the panel to overlap. Also fixes two other issues found while testing the change: 1. There was an extra small spacing on the right of the applet when not displaying the activity name. 2. The activity name could go past the widget when placed on the desktop. One other pre-existing problem that I couldn't solve is that when you place a new showActivityManager widget on the desktop, the initial width isn't big enough to contain the icon and text. FIXED-IN: 6.0.5 M +7 -2 applets/showActivityManager/package/contents/ui/main.qml https://invent.kde.org/plasma/plasma-desktop/-/commit/449be743eb6eb6decb9927442c11238fb0a05ab2 Git commit 0252c5b91ac50fb2516ae88b59fb18ce3b0085d1 by Nate Graham, on behalf of Edo Friedman. Committed on 09/05/2024 at 20:03. Pushed by ngraham into branch 'Plasma/6.0'. applets/showActivityManager: Fix and improve layout Fixes an issue where the showActivityManager applet was too small and caused some applets on the panel to overlap. Also fixes two other issues found while testing the change: 1. There was an extra small spacing on the right of the applet when not displaying the activity name. 2. The activity name could go past the widget when placed on the desktop. One other pre-existing problem that I couldn't solve is that when you place a new showActivityManager widget on the desktop, the initial width isn't big enough to contain the icon and text. FIXED-IN: 6.0.5 (cherry picked from commit 449be743eb6eb6decb9927442c11238fb0a05ab2) 7eb25d01 Improve layout of showActivityManager applet 83473830 Merge branch plasma-desktop:master into master M +7 -2 applets/showActivityManager/package/contents/ui/main.qml https://invent.kde.org/plasma/plasma-desktop/-/commit/0252c5b91ac50fb2516ae88b59fb18ce3b0085d1 *** Bug 460907 has been marked as a duplicate of this bug. *** |
Created attachment 166224 [details] Screenshot This is with kirigami 6.0.0, which is not available in the selection box The panel shows some glitches at startup: some icons are drawn on top of others, some at a too small size. Entering edit mode fixes the issues, restarting plasmashell makes them appear again Bisected to 6da5023bc90d81a182f71411e18721c5f425a807 Screenshot attached