Bug 481812

Summary:	Blue rectangle indicator for current VD got lost
Product:	[Plasma] kwin	Reporter:	postix <postix>
Component:	effects-desktop-grid	Assignee:	KWin default assignee <kwin-bugs-null>
Status:	RESOLVED FIXED
Severity:	normal	CC:	nate
Priority:	NOR	Keywords:	qt6, regression, usability
Version:	5.93.0
Target Milestone:	---
Platform:	Other
OS:	Linux
See Also:	https://bugs.kde.org/show_bug.cgi?id=459749 https://bugs.kde.org/show_bug.cgi?id=453999
Latest Commit:	https://invent.kde.org/plasma/kwin/-/commit/565faf1713af149f7adac82834ca1c9574a9c2d2	Version Fixed In:	6.0.2
Sentry Crash Report:
Attachments:	Screenshot

Description postix 2024-02-25 14:49:08 UTC

SUMMARY

In Plasma 5.27 there was a blue rectangle indicator for the current or hovered VD. This seems to be got lost in the transition to the new three-state design.

SOFTWARE/OS VERSIONS
Operating System: Fedora-KDE-Live-x86_64-Rawhide-20240225.n.0.iso
KDE Plasma Version: 6.0.0
KDE Frameworks Version: 6.0.0
Qt Version: 6.6.2
Kernel Version: 6.8.0-rc5
Graphics Platform: Wayland
Graphics Processor: llvmpipe
VirtualBox 7.0 on openSUSE TW

Comment 1 postix 2024-02-25 14:50:52 UTC

Created attachment 166091 [details]
Screenshot

Comment 2 Nate Graham 2024-02-26 21:57:57 UTC

Oops, can reproduce.

Comment 3 Bug Janitor Service 2024-02-28 10:58:24 UTC

A possibly relevant merge request was started @ https://invent.kde.org/plasma/kwin/-/merge_requests/5321

Comment 4 Akseli Lahtinen 2024-03-01 12:05:19 UTC

Git commit 181ce590a924e82cdc7302b876e17c588f595597 by Akseli Lahtinen.
Committed on 01/03/2024 at 12:05.
Pushed by akselmo into branch 'master'.

plugins/overview: Adds a border around hovered and selected desktop in desktopGrid

Currently desktop grid view is missing the selection rectangle when hovered over a desktop.
This adds the selection rectangle on hover, since it used to be there before three-state design.

Currently selected desktop has thinner and different colored border.


![image](/uploads/ad1f2f7acbe602fb7b9479ce859026b7/image.png)

![image](/uploads/9fa50bac4b81958da0b8926f8d2518ba/image.png)

![image](/uploads/3e46c1f5a740c40bbf18a5d887f31d39/image.png)

M  +10   -1    src/plugins/overview/qml/main.qml

https://invent.kde.org/plasma/kwin/-/commit/181ce590a924e82cdc7302b876e17c588f595597

Comment 5 Akseli Lahtinen 2024-03-01 12:16:35 UTC

Git commit 565faf1713af149f7adac82834ca1c9574a9c2d2 by Akseli Lahtinen.
Committed on 01/03/2024 at 12:05.
Pushed by akselmo into branch 'Plasma/6.0'.

plugins/overview: Adds a border around hovered and selected desktop in desktopGrid

Currently desktop grid view is missing the selection rectangle when hovered over a desktop.
This adds the selection rectangle on hover, since it used to be there before three-state design.

Currently selected desktop has thinner and different colored border.


![image](/uploads/ad1f2f7acbe602fb7b9479ce859026b7/image.png)

![image](/uploads/9fa50bac4b81958da0b8926f8d2518ba/image.png)

![image](/uploads/3e46c1f5a740c40bbf18a5d887f31d39/image.png)


(cherry picked from commit 181ce590a924e82cdc7302b876e17c588f595597)

9b22e56c Adds a border around hovered desktop in desktopGrid
0566df70 Simplify code
f4a4fd4c Use different color and spacing for already selected desktop
99a7fc51 Show borders only in desktop grid view
6c12f24a fix indent
a8981c94 Add parenthesis to ternary expressions, remove stray line
075b6117 Apply 1 suggestion(s) to 1 file(s)

M  +10   -1    src/plugins/overview/qml/main.qml

https://invent.kde.org/plasma/kwin/-/commit/565faf1713af149f7adac82834ca1c9574a9c2d2