| Summary: | Regression: EWS Server might require HTTP 1.1 | ||
|---|---|---|---|
| Product: | [Frameworks and Libraries] Akonadi | Reporter: | Igor Poboiko <igor.poboiko> |
| Component: | EWS Resource | Assignee: | kdepim bugs <kdepim-bugs> |
| Status: | RESOLVED FIXED | ||
| Severity: | normal | CC: | arojas, carl, krissn |
| Priority: | NOR | Keywords: | qt6 |
| Version: | 5.240.95 | ||
| Target Milestone: | --- | ||
| Platform: | Gentoo Packages | ||
| OS: | Linux | ||
| Latest Commit: | Version Fixed In: | ||
| Sentry Crash Report: | |||
|
Description
Igor Poboiko
2024-02-03 10:40:36 UTC
A possibly relevant merge request was started @ https://invent.kde.org/frameworks/kio/-/merge_requests/1546 A possibly relevant merge request was started @ https://invent.kde.org/pim/kdepim-runtime/-/merge_requests/146 Thanks for the quick response! I've applied both patches and tested it. Autodiscovery still doesn't work -- but now it fails with error "org.kde.pim.ews.client: Failed to process EWS request: Access denied to [URL]". (line 120 of ewspoxautodiscoverrequest.cpp: https://invent.kde.org/pim/kdepim-runtime/-/blob/master/resources/ews/ewsclient/ewspoxautodiscoverrequest.cpp?ref_type=heads#L120) However, the job error code is 115 (which is KIO::ERR_ACCESS_DENIED), instead of 401 Unauthorized, so it doesn't try authenticating with password (line 90 of ewsautodiscoveryjob.cpp: https://invent.kde.org/pim/kdepim-runtime/-/blob/master/resources/ews/ewsautodiscoveryjob.cpp?ref_type=heads#L90). Adding manual check for ERR_ACCESS_DENIED there solved this for me, and autodiscovery works. However, the resource still doesn't work because all other requests also fail with the same "HTTP/1.1 should be used" meassage. Adding the same line (set "HttpVersion" to "http1") to ewsrequest.cpp solved this for me as well, and resource now also works. (In reply to Igor Poboiko from comment #3) > Thanks for the quick response! I've applied both patches and tested it. > > Autodiscovery still doesn't work -- but now it fails with error > "org.kde.pim.ews.client: Failed to process EWS request: Access denied to > [URL]". > (line 120 of ewspoxautodiscoverrequest.cpp: > https://invent.kde.org/pim/kdepim-runtime/-/blob/master/resources/ews/ > ewsclient/ewspoxautodiscoverrequest.cpp?ref_type=heads#L120) > However, the job error code is 115 (which is KIO::ERR_ACCESS_DENIED), > instead of 401 Unauthorized, so it doesn't try authenticating with password > (line 90 of ewsautodiscoveryjob.cpp: > https://invent.kde.org/pim/kdepim-runtime/-/blob/master/resources/ews/ > ewsautodiscoveryjob.cpp?ref_type=heads#L90). Adding manual check for > ERR_ACCESS_DENIED there solved this for me, and autodiscovery works. > > However, the resource still doesn't work because all other requests also > fail with the same "HTTP/1.1 should be used" meassage. > Adding the same line (set "HttpVersion" to "http1") to ewsrequest.cpp solved > this for me as well, and resource now also works. Thanks for the helpful input. I adopted my kdepim-runtime patch. Happy to help! Proposed patches now fix both issues for me. Thanks, this fixes the resource not working at all for me since beta2. I still get disconnected after a couple of hours and need to relogin constantly, any ideas? https://bugs.kde.org/show_bug.cgi?id=478033 Git commit c7b139dd8d337407e64b8a20aa1574b2402e83d6 by Carl Schwan. Committed on 16/02/2024 at 10:30. Pushed by carlschwan into branch 'master'. ews: Use http1 for ews requests M +1 -0 resources/ews/ewsclient/ewspoxautodiscoverrequest.cpp M +1 -0 resources/ews/ewsclient/ewsrequest.cpp https://invent.kde.org/pim/kdepim-runtime/-/commit/c7b139dd8d337407e64b8a20aa1574b2402e83d6 Git commit cca3d3b1cb5672f7a528c23a46b1ce559d0257ad by Carl Schwan. Committed on 16/02/2024 at 10:45. Pushed by carlschwan into branch 'release/24.02'. ews: Use http1 for ews requests (cherry picked from commit c7b139dd8d337407e64b8a20aa1574b2402e83d6) M +1 -0 resources/ews/ewsclient/ewspoxautodiscoverrequest.cpp M +1 -0 resources/ews/ewsclient/ewsrequest.cpp https://invent.kde.org/pim/kdepim-runtime/-/commit/cca3d3b1cb5672f7a528c23a46b1ce559d0257ad Git commit 6ffee26847277d6077596a3b7c547a8d06fa98a7 by Carl Schwan. Committed on 16/02/2024 at 10:29. Pushed by carlschwan into branch 'master'. Allow to specify http1 only M +4 -0 src/kioworkers/http/http.cpp https://invent.kde.org/frameworks/kio/-/commit/6ffee26847277d6077596a3b7c547a8d06fa98a7 |