Bug 480360

Summary: No display of transactions with tags in split in the tag list
Product: [Applications] kmymoney Reporter: Ralf Habacker <ralf.habacker>
Component: generalAssignee: KMyMoney Devel Mailing List <kmymoney-devel>
Status: REPORTED ---    
Severity: normal    
Priority: NOR    
Version: 5.1.3   
Target Milestone: ---   
Platform: Other   
OS: Other   
Latest Commit: Version Fixed In:
Bug Depends on:    
Bug Blocks: 437827    
Attachments: test file
Screenshot from version 5.1.3

Description Ralf Habacker 2024-01-26 14:25:32 UTC
Created attachment 165246 [details]
test file

SUMMARY
Transactions with tags in splits are not displayed in the tag list.

STEPS TO REPRODUCE
1. start kmymoney
2. open the appended file
3. select tag list 

OBSERVED RESULT
Only transactions with a tag in the main field are displayed, tags in splits are not.

EXPECTED RESULT
Transaction with tags in splits should be also shown in the tag list.

SOFTWARE/OS VERSIONS
Linux: openSUSE Leap_15.5
KDE Frameworks Version: 5.103
Qt Version: 5.15

ADDITIONAL INFORMATION
Comment 1 Ralf Habacker 2024-01-30 09:19:54 UTC
Created attachment 165341 [details]
Screenshot from version 5.1.3

This works with version 5.1.3
Comment 2 Ralf Habacker 2024-01-30 09:21:57 UTC
Comment on attachment 165341 [details]
Screenshot from version 5.1.3

This screenshot was added to the wrong bug, moved to bug 480358
Comment 3 Ralf Habacker 2024-01-30 09:30:52 UTC
This is also an issue in version 5.1.3
Comment 4 Ralf Habacker 2024-01-30 15:19:38 UTC
The issue occurs when adding tags to a split related to a category account and was introduced with commit https://invent.kde.org/office/kmymoney/-/commit/1bd7b2e9d0d31f31771203f0474eac118836f21f, which seems to be an attempt to fix bug 437827.
Comment 5 Ralf Habacker 2024-01-30 15:21:55 UTC
(In reply to Ralf Habacker from comment #4)
> fix bug 437827.
This was the wrong bug number, the correct one is bug 440111.
Comment 6 Thomas Baumgart 2024-02-04 14:55:58 UTC
Git commit 796df584ef0bada68b6c98d75cd8a1af42c4b8ca by Thomas Baumgart.
Committed on 04/02/2024 at 12:59.
Pushed by tbaumgart into branch 'master'.

Assign tag to the category split

The initial implementation of tags assigned the selected tag to the
split for the account the transaction was entered. This is not useful as
the tag needs to be assigned to the category split.

This change makes sure that the tag is assigned to the category split.
Existing simple transactions can be fixed by opening them in the
transaction editor and saving them again. Multi split transactions need
to be fixed using the split editor.

The above described fix only works for individually selected
transactions. It is not supported when multiple transactions are
selected.
Related: bug 406403

M  +11   -1    kmymoney/views/multitransactioneditor.cpp
M  +35   -4    kmymoney/views/newtransactioneditor.cpp

https://invent.kde.org/office/kmymoney/-/commit/796df584ef0bada68b6c98d75cd8a1af42c4b8ca