| Summary: | Browser login for openconnect has fixed size | ||
|---|---|---|---|
| Product: | [Plasma] plasmashell | Reporter: | Paul de Vrieze <paul.devrieze> |
| Component: | Networks widget | Assignee: | Rahul Rameshbabu <sergeantsagara> |
| Status: | RESOLVED WAITINGFORINFO | ||
| Severity: | normal | CC: | chermnykh2001, daniel.weisser, deadmeu, dwt, fsundvik, karl, nicolas.fella, postix, sergeantsagara |
| Priority: | NOR | Keywords: | qt6, wayland-only |
| Version First Reported In: | master | ||
| Target Milestone: | 1.0 | ||
| Platform: | Other | ||
| OS: | Linux | ||
| See Also: | https://bugs.kde.org/show_bug.cgi?id=484747 | ||
| Latest Commit: | Version Fixed In: | ||
| Sentry Crash Report: | |||
| Attachments: |
Screenshot of the dialog
Issue seen in Wayland Issue not seen in X11 |
||
|
Description
Paul de Vrieze
2024-01-24 20:33:06 UTC
I had a bit of a look at the code. The code sets the webengine widget to 640x480: (https://invent.kde.org/plasma/plasma-nm/-/blob/Plasma/6.0/vpn/openconnect/openconnectauth.cpp#L604) But the UI file restricts the full widget to 360x360 (https://invent.kde.org/plasma/plasma-nm/-/blob/Plasma/6.0/vpn/openconnect/openconnectauth.ui#L9). Note that (on wayland) the window class is seen as kded6 (with fixed maximum size) - attempting to force the maximum size with kwin doesn't work. Created attachment 165199 [details]
Screenshot of the dialog
This shows the issue. For some strange reason even forcing window geometry doesn't change the size.
CC'ing the author of the relevant code This issue is introduced when transitioning from X to Wayland. The UI file is not "restricting" the geometry to 360x360 but setting the initial default geometry to this size. The code injects a new widget when SAML (SSO) capabilities are detected from the VPN gateway and changes the geometry appropriately due to the QLayouts used on the ui component for the auth dialog. You can see screenshots of the resize working correctly in the original authorship of this feature in the original MR. https://invent.kde.org/plasma/plasma-nm/-/merge_requests/208 This issue was also reported in a relevant MR. https://invent.kde.org/plasma/plasma-nm/-/merge_requests/316#note_848258 Hoping to submit a fix for this in Wayland this weekend. I actually used blind entry to actually be able to log in. Today I logged in again, and somehow the window was larger so I could see most of the relevant parts of the web page (still not perfect, but...). Created attachment 165553 [details]
Issue seen in Wayland
Created attachment 165554 [details]
Issue not seen in X11
Like I mentioned previously, this issue is only seen in Wayland. Hoping to have this resolved soon. A possibly relevant merge request was started @ https://invent.kde.org/plasma/plasma-nm/-/merge_requests/329 *** Bug 482874 has been marked as a duplicate of this bug. *** Could the priority of this be increased? This issue is blocking the use of the feature entirely. Actually, after trying again, this seems to no longer be an issue. (In reply to deadmeu from comment #12) > Actually, after trying again, this seems to no longer be an issue. There is an open MR with the fix > Actually, after trying again, this seems to no longer be an issue. For me it's definitely still an issue: With QT 6.6.2, the window can not be resized as reported in here in this issue. With QT 6.6.3 the login dialog is not shown at all, as reported in https://bugs.kde.org/show_bug.cgi?id=484874 I think this was fixed by QT 6.7, now the window is properly resized and shown. I'm not completely sure if that was the fix, but I did not see any relevant KDE updates when it was fixed for me, only the QT 6.7 update on Arch Linux. Bulk transfer as requested in T17796 Can anyone still reproduce this bug? There's a report that it seems to have been fixed since Qt 6.7 and later. 🐛🧹 ⚠️ This bug has been in NEEDSINFO status with no change for at least 15 days. Please provide the requested information, then set the bug status to REPORTED. If there is no change for at least 30 days, it will be automatically closed as RESOLVED WORKSFORME. For more information about our bug triaging procedures, please read https://community.kde.org/Guidelines_and_HOWTOs/Bug_triaging. Thank you for helping us make KDE software even better for everyone! It works properly for me now. Even supporting storing cookies. |