| Summary: | Standalone "Peek at Desktop", "Minimize all", and "Keyboard Layout" widgets inappropriately transfer focus to their parent Panel when activated | ||
|---|---|---|---|
| Product: | [Plasma] plasmashell | Reporter: | Fernando M. Muniz <fernandommuniz> |
| Component: | Show Desktop/Minimize All | Assignee: | Plasma Bugs List <plasma-bugs> |
| Status: | RESOLVED FIXED | ||
| Severity: | normal | CC: | accounts, alexinq6, butirsky, comradeferret, i.r.e.c.c.a.k.u.n+bugs.kde.org, julien.dlq, materka, medip642, michal.dybczak, nate, niccolo, panospolychronis, postix, tim |
| Priority: | HI | Keywords: | regression, usability |
| Version: | master | ||
| Target Milestone: | 1.0 | ||
| Platform: | Arch Linux | ||
| OS: | Linux | ||
| See Also: | https://bugs.kde.org/show_bug.cgi?id=477585 | ||
| Latest Commit: | https://invent.kde.org/plasma/libplasma/-/commit/abad7a55865f8ad2e936b34b33ffa5c2fe7d5598 | Version Fixed In: | 6.0.3 |
| Sentry Crash Report: | |||
|
Description
Fernando M. Muniz
2023-12-27 16:51:22 UTC
The same issue happens when minimizing all windows in front of the desktop, then trying to interact with the files by moving your arrow keys. The desktop should be the active area when it's the only area showing. Confirmed. It would be nice if clicking on it transferred focus to the desktop, yeah. Should i file another bug for the same issue when manually minimizing all windows to show the desktop? Nah, internally the widgets share most of their code, so let's cover both here. Updated the system info into the one that I currently have. (Same issue still happens) Problematic for folks who have unminimizable windows in the background that they use this widget as a shortcut for. Worked fine in 5. A possibly relevant merge request was started @ https://invent.kde.org/plasma/plasma-desktop/-/merge_requests/2110 Git commit 5909ac488df5fa469174387be4bb1ffe23578d0a by Nate Graham, on behalf of Niccolò Venerandi. Committed on 11/03/2024 at 17:56. Pushed by ngraham into branch 'master'. Panel: Don't take keyboard focus when one of its widgets is activated This re-introduces the workaround that was removed by Marco in `6a61a56bcd` Related: bug 482653 FIXED-IN: 6.0.2 M +4 -1 desktoppackage/contents/views/Panel.qml https://invent.kde.org/plasma/plasma-desktop/-/commit/5909ac488df5fa469174387be4bb1ffe23578d0a Git commit a98f5f84098723a8c0dffeeb4de75f6f240a3671 by Nate Graham, on behalf of Niccolò Venerandi. Committed on 11/03/2024 at 17:57. Pushed by ngraham into branch 'Plasma/6.0'. Panel: Don't take keyboard focus when one of its widgets is activated This re-introduces the workaround that was removed by Marco in `6a61a56bcd` Related: bug 482653 FIXED-IN: 6.0.2 (cherry picked from commit 5909ac488df5fa469174387be4bb1ffe23578d0a) 3bfe5033 Do not give panel keyboard focus when an applet is activated M +4 -1 desktoppackage/contents/views/Panel.qml https://invent.kde.org/plasma/plasma-desktop/-/commit/a98f5f84098723a8c0dffeeb4de75f6f240a3671 *** Bug 482653 has been marked as a duplicate of this bug. *** *** Bug 482058 has been marked as a duplicate of this bug. *** *** Bug 483235 has been marked as a duplicate of this bug. *** Re-opening as we have multiple reports of this still happening in Plasma 6.0.2, on both X11 and Wayland. I still can't reproduce those issues unfortunately. *** Bug 483928 has been marked as a duplicate of this bug. *** I noticed that all reporters use Arch btw. So much at this point it does not look like a coincedence. I checked just for sure that Arch packaged the fix correctly and they do, so it's most likely a coincidence (or, rather, most new Plasma 6 users are from Arch). (In reply to Hanabishi from comment #15) > I noticed that all reporters use Arch btw. So much at this point it does not > look like a coincedence. Someone reproduced it on opensuse tumbleweed and neon testing, it's not from arch only Ok, I just pointed out the pattern. But yeah, it explains simply by most early adopters being from Arch. A possibly relevant merge request was started @ https://invent.kde.org/plasma/libplasma/-/merge_requests/1082 *** Bug 484339 has been marked as a duplicate of this bug. *** I've seen the commits pushed to 6.0.2 and yet the bug is still present in 6.0.3. Am I missing something? I can reproduce the bug at any time 100% reliably. (In reply to Michał Dybczak from comment #21) > I've seen the commits pushed to 6.0.2 and yet the bug is still present in > 6.0.3. Am I missing something? > I can reproduce the bug at any time 100% reliably. The bugfix is accidentally missing from 6.0 where it should've been, but since it also caused some other issues we're investigating a better approach directly *** Bug 484417 has been marked as a duplicate of this bug. *** Git commit 6794ae6ab7c2c50f5ac57d7f32f5db1f7347201c by Nate Graham, on behalf of Niccolò Venerandi. Committed on 25/03/2024 at 19:05. Pushed by ngraham into branch 'master'. Do not activate containment when one of its applet is activated Reasoning is that some applets use "activated" when they would to trigger their action, e.g. the show desktop applet. If the containment (here, the panel) also gets activated as a result, it will get mouse input and a blue line will appear. Previously this was avoided by some hacky code that (a) apparently was not working for some people and (b) broke auto-hide and dodge windows after clicking on "Minimize all". This will also allow us to delete the hack in plasma-desktop. Related: bug 483941 FIXED-IN: 6.0.3 M +0 -4 src/plasma/containment.cpp https://invent.kde.org/plasma/libplasma/-/commit/6794ae6ab7c2c50f5ac57d7f32f5db1f7347201c Git commit 6203530a48a46e276d8e59452d23861118c1e362 by Nate Graham, on behalf of Niccolò Venerandi. Committed on 25/03/2024 at 19:06. Pushed by ngraham into branch 'master'. Revert "Panel: Don't take keyboard focus when one of its widgets is activated" This reverts commit 5909ac488df5fa469174387be4bb1ffe23578d0a. This is a companion to https://invent.kde.org/plasma/libplasma/-/merge_requests/1082, which removes need for this hack Related: bug 483941 M +1 -4 desktoppackage/contents/views/Panel.qml https://invent.kde.org/plasma/plasma-desktop/-/commit/6203530a48a46e276d8e59452d23861118c1e362 A possibly relevant merge request was started @ https://invent.kde.org/plasma/plasma-desktop/-/merge_requests/2143 Git commit e53fd6b066d569ae8247e5565c51560ace7af078 by Nate Graham, on behalf of Niccolò Venerandi. Committed on 25/03/2024 at 19:06. Pushed by ngraham into branch 'Plasma/6.0'. Revert "Panel: Don't take keyboard focus when one of its widgets is activated" This reverts commit 5909ac488df5fa469174387be4bb1ffe23578d0a. This is a companion to https://invent.kde.org/plasma/libplasma/-/merge_requests/1082, which removes need for this hack Related: bug 483941 (cherry picked from commit 6203530a48a46e276d8e59452d23861118c1e362) c2994876 Revert "Panel: Don't take keyboard focus when one of its widgets is activated" M +1 -4 desktoppackage/contents/views/Panel.qml https://invent.kde.org/plasma/plasma-desktop/-/commit/e53fd6b066d569ae8247e5565c51560ace7af078 Git commit abad7a55865f8ad2e936b34b33ffa5c2fe7d5598 by Nate Graham, on behalf of Niccolò Venerandi. Committed on 25/03/2024 at 19:10. Pushed by ngraham into branch 'Plasma/6.0'. Do not activate containment when one of its applet is activated Reasoning is that some applets use "activated" when they would to trigger their action, e.g. the show desktop applet. If the containment (here, the panel) also gets activated as a result, it will get mouse input and a blue line will appear. Previously this was avoided by some hacky code that (a) apparently was not working for some people and (b) broke auto-hide and dodge windows after clicking on "Minimize all". This will also allow us to delete the hack in plasma-desktop. Related: bug 483941 FIXED-IN: 6.0.3 (cherry picked from commit 6794ae6ab7c2c50f5ac57d7f32f5db1f7347201c) M +0 -1 src/plasma/containment.cpp https://invent.kde.org/plasma/libplasma/-/commit/abad7a55865f8ad2e936b34b33ffa5c2fe7d5598 Sorry, but I found leftovers of this issue: 1) If you have some of folders vertically aligned, then delete one, and press the left/right arrow keys; You no longer can use the up/down arrow keys to select the other folders. 2) The same happens if you indeed have a folder on the left/right, but it's not vertically aligned with the folder you just deleted. 2) Horizontally aligned*** Those are different issue; please don't re-open existing bug reports for them. |