Bug 478783

Summary:	Stop depending on QuickWebEngineDownloadRequest private header
Product:	[Applications] angelfish	Reporter:	Soren Stoutner <soren>
Component:	general	Assignee:	Jonah Brüchert <jbb>
Status:	RESOLVED FIXED
Severity:	normal
Priority:	NOR
Version First Reported In:	unspecified
Target Milestone:	---
Platform:	Debian testing
OS:	Linux
Latest Commit:		Version Fixed In:
Sentry Crash Report:

Description Soren Stoutner 2023-12-20 19:13:34 UTC

Angelfish currently depends on a private header for QuickWebEngineDownloadRequest.  This complicates efforts to maintain proper Qt WebEngine security support in Debian.  See the following two Debian bugs for context:

https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=1059164
https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=1057755

Qt 6 has a public version of this API:

https://doc.qt.io/qt-6/qml-qtwebengine-webenginedownloadrequest.html

But for some reason, Anglefish uses the private header instead of the public one, even though I can't see anything Anglefish is doing that can't be done with the public API.

From https://invent.kde.org/network/angelfish/-/blob/master/lib/angelfishwebprofile.cpp?ref_type=heads

    #include <private/qquickwebenginedownloadrequest_p.h>

If Anglefish does somehow need some functionality that is not included in the public API, the best course of action would probably be to request that Qt publicly expose that functionality.

Comment 1 Soren Stoutner 2023-12-22 21:46:41 UTC

I submitted an upstream bug report requesting that Qt make the needed parts of the API public.

https://bugreports.qt.io/browse/QTBUG-120370

Comment 2 Soren Stoutner 2024-08-26 20:16:01 UTC

Upstream has merged the API fixes in Qt WebEngine 6.8.0.

Comment 3 Soren Stoutner 2025-04-16 18:09:38 UTC

This was fixed in the following MR:

https://invent.kde.org/network/angelfish/-/merge_requests/234#f5354d09c8dc1352e28030598bae34c5f2857493