Summary: | Elisa mobile UI: playlist drawer cannot be closed anymore | ||
---|---|---|---|
Product: | [Applications] Elisa | Reporter: | Kevin Kofler <kevin.kofler> |
Component: | general | Assignee: | Matthieu Gallien <matthieu_gallien> |
Status: | RESOLVED FIXED | ||
Severity: | normal | CC: | julian.g, nate |
Priority: | NOR | ||
Version: | 23.08.3 | ||
Target Milestone: | --- | ||
Platform: | Manjaro | ||
OS: | Linux | ||
Latest Commit: | https://invent.kde.org/multimedia/elisa/-/commit/b8df28c83f3561e213a006b3c76971749506be72 | Version Fixed In: | 23.08.5 |
Description
Kevin Kofler
2023-12-05 19:51:22 UTC
I suspect that the regression is caused by this commit: https://invent.kde.org/multimedia/elisa/-/commit/6df31bbb78145633a187c56aa25389fee7e45a10 This should probably say: interactive: Kirigami.Settings.isMobile instead of: interactive: false Good catch. Would you like to submit a merge request? A possibly relevant merge request was started @ https://invent.kde.org/multimedia/elisa/-/merge_requests/528 Git commit 2d73416c9382b5b6a3535612719ff2c94dc0246a by Kevin Kofler. Committed on 10/12/2023 at 06:36. Pushed by kkofler into branch 'release/23.08'. Make context drawer interactive on mobile (#478121) src/qml/ElisaMainWindow.qml (contextDrawer): Change interactive: false to interactive: Kirigami.Settings.isMobile. Otherwise, it is impossible to close the context (playlist) drawer (with touch only) on mobile platforms such as the PinePhone. Update the comment accordingly. M +4 -3 src/qml/ElisaMainWindow.qml https://invent.kde.org/multimedia/elisa/-/commit/2d73416c9382b5b6a3535612719ff2c94dc0246a Git commit b8df28c83f3561e213a006b3c76971749506be72 by Kevin Kofler. Committed on 10/12/2023 at 06:45. Pushed by kkofler into branch 'master'. Make context drawer interactive on mobile (#478121) src/qml/ElisaMainWindow.qml (contextDrawer): Change interactive: false to interactive: Kirigami.Settings.isMobile. Otherwise, it is impossible to close the context (playlist) drawer (with touch only) on mobile platforms such as the PinePhone. Update the comment accordingly. M +4 -3 src/qml/ElisaMainWindow.qml https://invent.kde.org/multimedia/elisa/-/commit/b8df28c83f3561e213a006b3c76971749506be72 *** Bug 478388 has been marked as a duplicate of this bug. *** An update on when this fix will ship: This is already fixed in the development release 24.01.85 (24.02 Beta 2). The stable release 23.08.5, which will also include this fix (as it has already been pushed to the 23.08 release branch) is now scheduled for Thursday, February 15, 2024. The next feature release, 24.02.0, currently scheduled for Wednesday, February 28, 2024, will also include this fix. Distributions may of course backport the fix earlier. The Manjaro ARM elisa-qtmm package is already patched. |