| Summary: | The playlist in party mode in Elisa is broken | ||
|---|---|---|---|
| Product: | [Frameworks and Libraries] frameworks-qqc2-desktop-style | Reporter: | maan <martin.ang.angelov> |
| Component: | general | Assignee: | kdelibs bugs <kdelibs-bugs-null> |
| Status: | RESOLVED FIXED | ||
| Severity: | normal | CC: | ahiemstra, jackhill3103, kde, nate, noahadvs, notmart |
| Priority: | VHI | Keywords: | qt6 |
| Version First Reported In: | 5.246.0 | ||
| Target Milestone: | --- | ||
| Platform: | Neon | ||
| OS: | Linux | ||
| Latest Commit: | https://invent.kde.org/frameworks/qqc2-desktop-style/-/commit/b0167e224fa1eaa6c1c94322102b8fd61073f39a | Version Fixed/Implemented In: | |
| Sentry Crash Report: | |||
| Attachments: |
screenshot light theme
2.png - screenshot dark theme |
||
|
Description
maan
2023-11-30 19:16:05 UTC
Created attachment 163666 [details]
screenshot light theme
Created attachment 163667 [details]
2.png - screenshot dark theme
Thanks for reporting this. It looks like you uploaded the wrong attachments though. Also, did you mean to post this in the upnp component or the general component? (In reply to Jack Hill from comment #3) > Thanks for reporting this. It looks like you uploaded the wrong attachments > though. Also, did you mean to post this in the upnp component or the general > component? The attachments in the summary are broken, I do not know why. But i have added the 2 attachments as comments 1 and 2 below. I do not know where should I have posted this. Should I move it under the general component? Ah, I didn't realise those two attachments were different. I can confirm this now. The UPnP component is for universal plug and play, which I believe is broken in Elisa. I've moved it to general now. Eek, can confirm. Looks like this is a regression from porting to be base on ItemDelegate. The base unhovered background color isn't transparent like it probably should be. A possibly relevant merge request was started @ https://invent.kde.org/frameworks/qqc2-desktop-style/-/merge_requests/338 Git commit b0167e224fa1eaa6c1c94322102b8fd61073f39a by Nate Graham. Committed on 08/12/2023 at 00:21. Pushed by ngraham into branch 'master'. Don't set a background color for normal unhovered list items Currently the background styling we apply to ItemDelegate and others uses the Kirigami theme's standard view background color for the backgrounds of unhovered list items not using the alternate background color. But this is unnecessary; when the list item is in a view that itself uses the view background color, then the list item's own background color simply matches that of the view it lives in. And when the view intentionally does not use that background color, the result is visual brokenness. We can fix this by simply not setting a background color for the normal unhovered state of the background. M +1 -1 org.kde.desktop/private/DefaultListItemBackground.qml https://invent.kde.org/frameworks/qqc2-desktop-style/-/commit/b0167e224fa1eaa6c1c94322102b8fd61073f39a |