| Summary: | Occasional duplicate received posts when there is a picture/video in it. | ||
|---|---|---|---|
| Product: | [Applications] Tokodon | Reporter: | Kevin Frost <kevin> |
| Component: | general | Assignee: | Unassigned bugs <unassigned-bugs-null> |
| Status: | RESOLVED FIXED | ||
| Severity: | minor | CC: | carl, josh |
| Priority: | NOR | Keywords: | wayland-only |
| Version First Reported In: | 23.08.3 | ||
| Target Milestone: | --- | ||
| Platform: | Ubuntu | ||
| OS: | Other | ||
| Latest Commit: | https://invent.kde.org/network/tokodon/-/commit/8ec7279b9771cf1aa5701704e7795cc3c7d41b17 | Version Fixed In: | 25.04 |
| Sentry Crash Report: | |||
| Attachments: |
Tokodon duplicate posts
Duplicate pictures attachment-3371063-0.html |
||
|
Description
Kevin Frost
2023-11-23 14:05:30 UTC
Created attachment 163396 [details]
Tokodon duplicate posts
Although this recording was done on X11, the problem occurs on both X11 and Wayland.
Comment on attachment 163396 [details]
Tokodon duplicate posts
furthermore, logging out and back in again clears the duplicate video.
I still can't reproduce this, and I use Tokodon a lot and have media on my feed. Can you see if this happens in the latest version (24.08)? Thanks! Created attachment 176183 [details]
Duplicate pictures
I have been monitoring using two different apps plus the Mastondonapp.uk website and the duplication only exists on Tokodon 24.08.3.
Is there anyway of I can help debug this Flatpak version?
Oh, so this is when the post is "streamed in" while you have the timeline open? Created attachment 176186 [details] attachment-3371063-0.html Yes it is. On 28/11/2024 13:32, Joshua Goins wrote: > https://bugs.kde.org/show_bug.cgi?id=477420 > > Joshua Goins<josh@redstrate.com> changed: > > What |Removed |Added > ---------------------------------------------------------------------------- > Status|NEEDSINFO |CONFIRMED > Resolution|WAITINGFORINFO |--- > > --- Comment #5 from Joshua Goins<josh@redstrate.com> --- > Oh, so this is when the post is "streamed in" while you have the timeline open? > Awesome! I'm going to look into revamping the streaming soon, and will be on the lookout for this bug A possibly relevant merge request was started @ https://invent.kde.org/network/tokodon/-/merge_requests/693 Git commit 8ec7279b9771cf1aa5701704e7795cc3c7d41b17 by Joshua Goins. Committed on 20/01/2025 at 01:01. Pushed by redstrate into branch 'master'. Improve refreshing the main timeline, other misc fixes Currently refreshing the main timeline involves throwing everything away and starting fresh, but we don't need to do that. Now we use the pagination to load all newer posts, and we're a bit smarter about it too. An additional bug that I think I fixed is receiving duplicate posts. Now fetchedTimeline and handleEvent shouldn't add posts we have already. A bug that I ran into but not sure if it's ever resulted in a crash is not checking if posts is empty before calling first() on it, but good to fix anyway. Related: bug 495996 M +1 -1 src/autotests/data/status-poll.json M +10 -4 src/autotests/timelinetest.cpp M +30 -11 src/timeline/maintimelinemodel.cpp M +15 -0 src/timeline/timelinemodel.cpp https://invent.kde.org/network/tokodon/-/commit/8ec7279b9771cf1aa5701704e7795cc3c7d41b17 |