Bug 477257

Summary: "Apply Settings" dialog scrolls unnecessarily
Product: [Frameworks and Libraries] frameworks-kirigami Reporter: Nicolas Fella <nicolas.fella>
Component: generalAssignee: kdelibs bugs <kdelibs-bugs-null>
Status: RESOLVED FIXED    
Severity: normal CC: bugseforuns, kde, me, nate, notmart
Priority: NOR Keywords: qt6
Version First Reported In: Master   
Target Milestone: 1.0   
Platform: Other   
OS: Linux   
Latest Commit: Version Fixed/Implemented In:
Sentry Crash Report:
Attachments: Screenshot
Screenshot, scrolled down

Description Nicolas Fella 2023-11-20 00:20:29 UTC
Created attachment 163303 [details]
Screenshot

STEPS TO REPRODUCE
1. Right click on desktop 
2. Configure Desktop and Wallpaper
3. Change something in the wallpaper settings
4. Go to "Mouse Actions"

OBSERVED RESULT
A prompt to apply/discard the settings appears.
It is scrollable despite the text all fitting and has a bunch of whitespace at the end

EXPECTED RESULT
Only scrolls when text is too long

SOFTWARE/OS VERSIONS
KDE Plasma Version: master
KDE Frameworks Version: master
Qt Version: 6.6
Comment 1 Nicolas Fella 2023-11-20 00:21:10 UTC
Created attachment 163304 [details]
Screenshot, scrolled down
Comment 2 Nate Graham 2023-11-27 18:03:55 UTC
Cannot reproduce today; can you?
Comment 3 Bug Janitor Service 2023-12-12 03:45:54 UTC
Dear Bug Submitter,

This bug has been in NEEDSINFO status with no change for at least
15 days. Please provide the requested information as soon as
possible and set the bug status as REPORTED. Due to regular bug
tracker maintenance, if the bug is still in NEEDSINFO status with
no change in 30 days the bug will be closed as RESOLVED > WORKSFORME
due to lack of needed information.

For more information about our bug triaging procedures please read the
wiki located here:
https://community.kde.org/Guidelines_and_HOWTOs/Bug_triaging

If you have already provided the requested information, please
mark the bug as REPORTED so that the KDE team knows that the bug is
ready to be confirmed.

Thank you for helping us make KDE software even better for everyone!
Comment 4 Bug Janitor Service 2023-12-27 03:46:32 UTC
This bug has been in NEEDSINFO status with no change for at least
30 days. The bug is now closed as RESOLVED > WORKSFORME
due to lack of needed information.

For more information about our bug triaging procedures please read the
wiki located here:
https://community.kde.org/Guidelines_and_HOWTOs/Bug_triaging

Thank you for helping us make KDE software even better for everyone!
Comment 5 Nicolas Fella 2024-01-13 20:21:39 UTC Comment hidden (spam)
Comment 6 Nicolas Fella 2024-01-13 20:22:42 UTC
*** Bug 479743 has been marked as a duplicate of this bug. ***
Comment 7 Nicolas Fella 2024-01-13 20:24:14 UTC
I can't reproduce, but Patrick can, apparently
Comment 8 Nicolas Fella 2024-01-13 20:31:12 UTC
I can reproduce on Fedora Rawhide/Beta 2/Qt 6.6, but not on master/Qt 6.7
Comment 9 Marco Martin 2024-01-16 12:23:51 UTC
Seems to be a generic kirigami issue of PromptDialog
Comment 10 Bug Janitor Service 2024-01-16 13:09:55 UTC
A possibly relevant merge request was started @ https://invent.kde.org/frameworks/kirigami/-/merge_requests/1431
Comment 11 Marco Martin 2024-01-16 19:55:06 UTC
Git commit 9a04b5709605bc9610fb7c30977238a198d7aab8 by Marco Martin.
Committed on 16/01/2024 at 14:05.
Pushed by mart into branch 'master'.

Explicitly bind the calculated implicit height to the flickable contentHeight

Items that can change dinamically their size won't play well with the
auto-created flickable of a SvrollView, as in that case the flickable's
contentHeight needs to be explicitly binded.

Do it after we are sure there is a flickable in the ScrollView as we
don't want to trigger an early creation of  the internal flickable as
the
client code might be wanting to assign a custom created flickable or
item view

M  +12   -0    src/controls/Dialog.qml

https://invent.kde.org/frameworks/kirigami/-/commit/9a04b5709605bc9610fb7c30977238a198d7aab8