| Summary: | Audio CDs KCM prompts to save/discard changes even when nothing was changed | ||
|---|---|---|---|
| Product: | [Applications] systemsettings | Reporter: | Patrick Silva <bugseforuns> |
| Component: | kcm_audiocd | Assignee: | Plasma Bugs List <plasma-bugs-null> |
| Status: | RESOLVED FIXED | ||
| Severity: | normal | CC: | me |
| Priority: | NOR | Keywords: | qt6, regression |
| Version First Reported In: | 5.92.0 | ||
| Target Milestone: | --- | ||
| Platform: | Arch Linux | ||
| OS: | Linux | ||
| Latest Commit: | https://invent.kde.org/multimedia/audiocd-kio/-/commit/a4dc87c18adaf43f2441a874caa6416121e2b62a | Version Fixed In: | |
| Sentry Crash Report: | |||
|
Description
Patrick Silva
2023-11-07 12:19:22 UTC
On Plasma 6 RC1, System Settings even crashes when I click on "Apply" or "Discard" button of apply/discard dialog. *** Bug 481210 has been marked as a duplicate of this bug. *** A possibly relevant merge request was started @ https://invent.kde.org/multimedia/audiocd-kio/-/merge_requests/12 Git commit 92a474ba8b8fc87096348559d58e56b10c1cb788 by Nicolas Fella. Committed on 20/02/2024 at 09:31. Pushed by nicolasfella into branch 'master'. Only mark KCM as changed when text was actually edited textChanged is also emitted when setText is called, which we do on load This causes the KCM to be always marked as changed even when the user never changed anything Use textEdited, which is only emitted when a human changed it M +9 -9 kcmaudiocd/kcmaudiocd.cpp https://invent.kde.org/multimedia/audiocd-kio/-/commit/92a474ba8b8fc87096348559d58e56b10c1cb788 Git commit a4dc87c18adaf43f2441a874caa6416121e2b62a by Nicolas Fella. Committed on 20/02/2024 at 16:29. Pushed by nicolasfella into branch 'release/24.02'. Only mark KCM as changed when text was actually edited textChanged is also emitted when setText is called, which we do on load This causes the KCM to be always marked as changed even when the user never changed anything Use textEdited, which is only emitted when a human changed it (cherry picked from commit 92a474ba8b8fc87096348559d58e56b10c1cb788) M +9 -9 kcmaudiocd/kcmaudiocd.cpp https://invent.kde.org/multimedia/audiocd-kio/-/commit/a4dc87c18adaf43f2441a874caa6416121e2b62a |