| Summary: | Plastik and other 3rd-party window decoration themes do not work on X11 | ||
|---|---|---|---|
| Product: | [Plasma] kwin | Reporter: | Zoey Ahmed <bruhzakahmed420666> |
| Component: | decorations | Assignee: | KWin default assignee <kwin-bugs-null> |
| Status: | RESOLVED FIXED | ||
| Severity: | major | CC: | kde, nate |
| Priority: | NOR | Keywords: | qt6 |
| Version First Reported In: | master | ||
| Target Milestone: | --- | ||
| Platform: | Neon | ||
| OS: | Linux | ||
| See Also: | https://bugs.kde.org/show_bug.cgi?id=477085 | ||
| Latest Commit: | https://invent.kde.org/plasma/kwin/-/commit/b01b626ca81d23583a8c33307a94874a8ff0ad37 | Version Fixed/Implemented In: | |
| Sentry Crash Report: | |||
|
Description
Zoey Ahmed
2023-11-06 23:43:35 UTC
Confirmed. I tested a few random themes from GHNS in addition to Plastik and none of them work on X11. Could you take a screen recording so I can see exactly what's happening? Thanks! (In reply to Nate Graham from comment #2) > Could you take a screen recording so I can see exactly what's happening? > Thanks! Here is it on X11 https://youtube.com/shorts/dZ8Kv3ssxiY Here is it working on Wayland as intended https://youtube.com/shorts/WcNtfLnwpLM Very interesting, thanks. Can I ask a few more questions? 1. Is it working on X11 with the Breeze window decoration theme, not Plastik? How about a 3rd-party window decoration theme? 2. Are any of the buttons on the titlebar interactive when it's in this state? Or no? 3. Do any of the titlebar buttons *visually* react when clicked while the titlebar is in this state? (In reply to Nate Graham from comment #4) > Very interesting, thanks. Can I ask a few more questions? > 1. Is it working on X11 with the Breeze window decoration theme, not > Plastik? How about a 3rd-party window decoration theme? > 2. Are any of the buttons on the titlebar interactive when it's in this > state? Or no? > 3. Do any of the titlebar buttons *visually* react when clicked while the > titlebar is in this state? Hello, sorry ive been quite busy with school so i didnt respond quickly, anyways: 1. Breeze decorations work as expected on X11 on all accounts. 2. The close button does go a shade of red when hovered over, but that is it. 3. No Thanks. Do any 3rd-party window decoration themes also exhibit these issues? Or is it just Plastik? (In reply to Nate Graham from comment #6) > Thanks. Do any 3rd-party window decoration themes also exhibit these issues? > Or is it just Plastik? 3rd party window decorations have exactly the same issuses as Plastik. Only Breeze works as intended Can reproduce. A possibly relevant merge request was started @ https://invent.kde.org/plasma/kwin/-/merge_requests/4742 Git commit b01b626ca81d23583a8c33307a94874a8ff0ad37 by Vlad Zahorodnii. Committed on 05/12/2023 at 23:04. Pushed by vladz into branch 'master'. x11: Fix MouseButtonPress events sent to decoration ButtonPressEvent::state includes keys and buttons prior to the button press has been generated. On the other hand, it appears that QMouseEvent::buttons() should include currently pressed buttons, i.e. the button that has been just pressed should be in that bitfield. This is important for QQuickDeliveryAgent, which checks QMouseEvent::button() and QMouseEvent::buttons() to decide whether to send the button event only to tap handlers or both tap handlers and mouse areas. M +12 -4 src/events.cpp https://invent.kde.org/plasma/kwin/-/commit/b01b626ca81d23583a8c33307a94874a8ff0ad37 |