Bug 476505

Summary: Masked Opacity/Flow are not enabled on old brushes
Product: [Applications] krita Reporter: Freya Lupen <penguinflyer2222>
Component: Brush enginesAssignee: Krita Bugs <krita-bugs-null>
Status: RESOLVED FIXED    
Severity: normal CC: croceami, dimula73, reine.kurth
Priority: NOR Keywords: regression, release_blocker
Version: 5.2.1   
Target Milestone: ---   
Platform: Other   
OS: Other   
Latest Commit: Version Fixed In:
Attachments: WaterC Basic Round-Grain versions comparsion

Description Freya Lupen 2023-11-03 13:39:25 UTC
Created attachment 162840 [details]
WaterC Basic Round-Grain versions comparsion

SUMMARY
In 5.2.1, Masked Opacity and Masked Flow aren't enabled on existing brushes by default, only if it's manually enabled and resaved. This affects the behavior of the default brush "j) WaterC Basic Round-Grain" as shown in the attached image, as well as other brushes like Ramon's "inkP 06 Dip Pen Diluted".

STEPS TO REPRODUCE
1. Try to use a brush that makes use of Masked Opacity or Masked Flow, such as "j) WaterC Basic Round-Grain".

OBSERVED RESULT
The brush behaves differently, with no Masked Opacity/Flow.

EXPECTED RESULT
The brush behaves as before, using Masked Opacity/Flow.

SOFTWARE/OS VERSIONS
Krita 5.2.1
Comment 1 Dmitry Kazakov 2023-11-03 16:49:42 UTC
Git commit 81161814ad4f646ae8c456a349128751d8e0b825 by Dmitry Kazakov.
Committed on 03/11/2023 at 17:49.
Pushed by dkazakov into branch 'master'.

Disable checkability of Opacity and Flow options for Masked Brushes

They were uncheckable before Krita 5.2.0, so we should keep them this
way. That is a proper fix for the incorrect fix for bug 476076.
Related: bug 476076

M  +1    -1    plugins/paintops/defaultpaintops/brush/kis_brushop_settings_widget.cpp
M  +2    -2    plugins/paintops/libpaintop/KisStandardOptionData.h

https://invent.kde.org/graphics/krita/-/commit/81161814ad4f646ae8c456a349128751d8e0b825
Comment 2 Dmitry Kazakov 2023-11-03 16:49:59 UTC
Git commit f49342bc1cc2bc968ae5b1176583716713aa6359 by Dmitry Kazakov.
Committed on 03/11/2023 at 17:49.
Pushed by dkazakov into branch 'krita/5.2'.

Disable checkability of Opacity and Flow options for Masked Brushes

They were uncheckable before Krita 5.2.0, so we should keep them this
way. That is a proper fix for the incorrect fix for bug 476076.
Related: bug 476076

M  +1    -1    plugins/paintops/defaultpaintops/brush/kis_brushop_settings_widget.cpp
M  +2    -2    plugins/paintops/libpaintop/KisStandardOptionData.h

https://invent.kde.org/graphics/krita/-/commit/f49342bc1cc2bc968ae5b1176583716713aa6359
Comment 3 Reine 2023-11-20 11:13:33 UTC
*** Bug 477151 has been marked as a duplicate of this bug. ***
Comment 4 Dmitry Kazakov 2023-12-01 11:24:24 UTC
*** Bug 477828 has been marked as a duplicate of this bug. ***