Bug 474307

Summary: Assigning Tokens "A", "B", ... does not work anymore in viewer mode
Product: [Applications] kphotoalbum Reporter: Andreas Schleth <schleth_es>
Component: ViewerAssignee: KPhotoAlbum Bugs <kpabugs>
Status: RESOLVED NOT A BUG    
Severity: normal CC: johannes
Priority: NOR    
Version: GIT master   
Target Milestone: ---   
Platform: openSUSE   
OS: Linux   
Latest Commit: Version Fixed In:
Sentry Crash Report:

Description Andreas Schleth 2023-09-08 18:29:00 UTC 
STEPS TO REPRODUCE
1. view a few images in viewer mode (full screen or window)
2. hit some letter key to assign a token for one or some of them
3. check whether the token has been assigned

OBSERVED RESULT

None of the tokens has been assigned. (This worked before!)

EXPECTED RESULT

The images should have the respective tokens assigned.

SOFTWARE/OS VERSIONS
KPA: v5.11.0-92-g28815029
Linux/KDE Plasma: 
KDE Plasma Version: 
KDE Frameworks Version: 5.103.0
Qt Version: 5.15.8 

ADDITIONAL INFORMATION

I did a git bisect and found the bad commit [Hi Jesper! :-)]:

3a130ed45089c1b043bea8834a23be0438b4ee17 is the first bad commit
commit 3a130ed45089c1b043bea8834a23be0438b4ee17
Author: Jesper K. Pedersen <jesper.pedersen@kdab.com>
Date:   Mon Jul 24 10:08:51 2023 +0200

    Support annotating images from the viewer

 .reuse/dep5                        |   4 +
 CHANGELOG.md                       |   3 +-
 CMakeLists.txt                     |  21 +-
 DB/CategoryCollection.cpp          |  12 ++
 DB/CategoryCollection.h            |  10 +-
 DB/GlobalCategorySortOrder.cpp     |  74 +++++++
 DB/GlobalCategorySortOrder.h       |  49 +++++
 DB/ImageDB.cpp                     |   2 +-
 DB/XML/FileReader.cpp              |  17 ++
 DB/XML/FileReader.h                |   1 +
 DB/XML/FileWriter.cpp              |  11 +
 DB/XML/FileWriter.h                |   1 +
 MainWindow/Window.cpp              |   3 +-
 MainWindow/Window.h                |   1 -
 Utilities/DescriptionUtil.cpp      |   3 +
 Viewer/AnnotationHandler.cpp       | 126 ++++++++++++
 Viewer/AnnotationHandler.h         |  46 +++++
 Viewer/CursorVisibilityHandler.cpp |  79 ++++++++
 Viewer/CursorVisibilityHandler.h   |  34 ++++
 Viewer/ImageDisplay.cpp            |  55 +----
 Viewer/ImageDisplay.h              |   7 -
 Viewer/SelectCategoryAndValue.cpp  | 212 ++++++++++++++++++++
 Viewer/SelectCategoryAndValue.h    |  38 ++++
 Viewer/SelectCategoryAndValue.ui   | 175 ++++++++++++++++
 Viewer/SpeedDisplay.cpp            |  88 --------
 Viewer/SpeedDisplay.h              |  41 ----
 Viewer/TransientDisplay.cpp        |  78 ++++++++
 Viewer/TransientDisplay.h          |  42 ++++
 Viewer/ViewerWidget.cpp            | 397 ++++++++++++++++++++-----------------
 Viewer/ViewerWidget.h              |  48 +++--
 Viewer/documentation.h             |   2 +-
 doc/annotation-mode.png            | Bin 0 -> 149131 bytes
 doc/assign-macro-add-new-value.png | Bin 0 -> 20497 bytes
 doc/assign-macro-overview.png      | Bin 0 -> 51638 bytes
 doc/assign-macro-step1.png         | Bin 0 -> 20504 bytes
 doc/assign-macro-step2.png         | Bin 0 -> 14579 bytes
 doc/draw-on-image.png              | Bin 401217 -> 0 bytes
 doc/setting-properties.docbook     |  21 +-
 doc/viewer.docbook                 | 227 ++++++++-------------
 39 files changed, 1374 insertions(+), 554 deletions(-)
 create mode 100644 DB/GlobalCategorySortOrder.cpp
 create mode 100644 DB/GlobalCategorySortOrder.h
 create mode 100644 Viewer/AnnotationHandler.cpp
 create mode 100644 Viewer/AnnotationHandler.h
 create mode 100644 Viewer/CursorVisibilityHandler.cpp
 create mode 100644 Viewer/CursorVisibilityHandler.h
 create mode 100644 Viewer/SelectCategoryAndValue.cpp
 create mode 100644 Viewer/SelectCategoryAndValue.h
 create mode 100644 Viewer/SelectCategoryAndValue.ui
 delete mode 100644 Viewer/SpeedDisplay.cpp
 delete mode 100644 Viewer/SpeedDisplay.h
 create mode 100644 Viewer/TransientDisplay.cpp
 create mode 100644 Viewer/TransientDisplay.h
 create mode 100644 doc/annotation-mode.png
 create mode 100644 doc/assign-macro-add-new-value.png
 create mode 100644 doc/assign-macro-overview.png
 create mode 100644 doc/assign-macro-step1.png
 create mode 100644 doc/assign-macro-step2.png
 delete mode 100644 doc/draw-on-image.png
Comment 1 Johannes Zarl-Zierl 2023-09-08 21:10:06 UTC 
Hi Andreas,

This is actually not a bug, but due to a new feature. To quote the changelog for the upcoming version:

### Added
 - Support annotating images from the viewer by using letters to assign tags.
   Use the context menu and select "Annotate | Assign Tags" to enable.
   More information is available in the KPhotoAlbum handbook.
 
### Changed
 - In the viewer window, using the letters A-Z to assign tokens now needs to be explicitly enabled.
   You can do this by opening the context menu and selecting "Annotate | Assign Tokens".
Comment 2 Andreas Schleth 2023-09-08 21:42:52 UTC 
Hi Johannes, 

I stand corrected. Thanks for educating me about this new and unexpected feature.
However, I did not find anything about this in the release notes (which I read) and as a long time user of KPA I do not consult the manual ("Users never read manuals" :-).

Unfortunately, the change (crtl-T) is not permanent, which is what I would prefer.

Maybe we can elevate this issue to an enhancement request:
"Let me chose the default setting somewhere in the viewer settings." 
This would also have the benefit to move this hidden feature a bit more to the front.

Cheers, Andreas
Comment 3 Johannes Zarl-Zierl 2023-09-08 23:55:11 UTC 
You didn't miss anything in the release notes - this feature is not yet part of an official release... ;-)

I've added a wishlist bug with your concerns: bug #474317