| Summary: | Dark Icons on Dark Themes, resulting in poor contrast | ||
|---|---|---|---|
| Product: | [Applications] Tokodon | Reporter: | Izzy Jackson <izzyjackson05> |
| Component: | general | Assignee: | Joshua Goins <josh> |
| Status: | RESOLVED FIXED | ||
| Severity: | normal | CC: | carl, d4r1us-drk, josh |
| Priority: | NOR | ||
| Version: | 23.08.0 | ||
| Target Milestone: | --- | ||
| Platform: | unspecified | ||
| OS: | Linux | ||
| Latest Commit: | Version Fixed In: | 23.12 | |
| Sentry Crash Report: | |||
| Attachments: |
See the screenshot, dark icons are used, which makes them illegible agains the light theme.
Regular Breeze Icons on Dark Colours Regular Breeze Icons on Breeze Dark Colour Scheme in Tokodon Breeze Dark Icons with Default Colours |
||
|
Description
Izzy Jackson
2023-08-31 00:43:38 UTC
Someone else seems to have run into this issue on Flatpak as well, really weird Update: It's not just Flatpak on Kubuntu that's being problematic, running it as a native .RPM package on Fedora 38 also seems to be weird. If I launch it with the regular Breeze icon (attached screenshot), it works fine - icons are light against a dark background, and if I change the app's colour scheme to Breeze Light, it's dark on light. But if I load it with the Breeze Dark icon theme, it has the issue of poor contrast against the dark background. Elisa and Welcome Centre don't have this issue, so I'm confident in saying this is a Tokodon issue. Created attachment 161604 [details]
Regular Breeze Icons on Dark Colours
Created attachment 161605 [details]
Regular Breeze Icons on Breeze Dark Colour Scheme in Tokodon
Interestingly, as I was testing this out, I found that if I set the in-app colour scheme to Breeze Dark as opposed to default, it works fine and the only difference is that it doesn't follow the UI theme.
Created attachment 161606 [details]
Breeze Dark Icons with Default Colours
If I use default colours, it has issues. The system theme is still Breeze Dark, just with an Accent Colour applied.
Apologies for comments spam, I can only set one image at a time by the looks of things. Hopefully this makes it easier to solve.
Thanks for the really detailed testing! This gives me much more to work with. I cannot reproduce on 23.08.2 anymore, at least with the Flatpak (Breeze or Breeze Dark icons). However, I suggest sticking to "Breeze" and not "Breeze Dark" as icons should color automatically. In the next major release, all of the icon bugginess _should_ go away and icons should show the same behavior as other KDE applications. Unfortunately that's all I can really do as my bandwidth is limited :( If more people experience this issue, I might backport our fix early and see how that works. (In reply to Joshua Goins from comment #7) > I cannot reproduce on 23.08.2 anymore, at least with the Flatpak (Breeze or > Breeze Dark icons). However, I suggest sticking to "Breeze" and not "Breeze > Dark" as icons should color automatically. > > In the next major release, all of the icon bugginess _should_ go away and > icons should show the same behavior as other KDE applications. Unfortunately > that's all I can really do as my bandwidth is limited :( If more people > experience this issue, I might backport our fix early and see how that works. I'm still having this issue in the latest Flatpak release. Either with Breeze or Breeze Dark icons. |