| Summary: | Items in some KCMs don't get highlighted when hovering with the mouse | ||
|---|---|---|---|
| Product: | [Applications] systemsettings | Reporter: | guimarcalsilva |
| Component: | general | Assignee: | Plasma Bugs List <plasma-bugs-null> |
| Status: | RESOLVED FIXED | ||
| Severity: | normal | CC: | bugseforuns, isma.af, kde, nate |
| Priority: | NOR | Keywords: | qt6 |
| Version First Reported In: | master | ||
| Target Milestone: | --- | ||
| Platform: | Neon | ||
| OS: | Linux | ||
| Latest Commit: | Version Fixed In: | ||
| Sentry Crash Report: | |||
|
Description
guimarcalsilva
2023-08-04 19:35:22 UTC
Can reproduce. Git commit 9add143a40f10a85fb5d9c319013381c1458ba02 by Ismael Asensio. Committed on 18/08/2023 at 20:39. Pushed by iasensio into branch 'master'. kcms/decoration: Fix highlight when hovering the preview The preview item implements hover event filters, which by default are accepted and not propagated to their parent, breaking the hightlight on hover for the GridView. We can simply "ignore()" those events so they are propagated, but still fully functional. Preemptively, do the same also for mouse events, which seem to be already propagated now, but shouldn't according to the QQuickItem documentation. M +2 -0 src/kcms/decoration/declarative-plugin/previewitem.cpp https://invent.kde.org/plasma/kwin/-/commit/9add143a40f10a85fb5d9c319013381c1458ba02 A possibly relevant merge request was started @ https://invent.kde.org/plasma/plasma-workspace/-/merge_requests/3196 Git commit 242a9b7e79c04beeb99a0127c83a32bac1e4555e by Ismael Asensio. Committed on 18/08/2023 at 20:46. Pushed by iasensio into branch 'master'. kcms/style: Fix highlight when hovering the preview The PreviewItem implements hover event filters, which by default are accepted and not propagated to their parent, breaking the hightlight on hover for the GridView. We can simply "ignore()" those events so they are propagated, but still fully functional. M +4 -1 kcms/style/previewitem.cpp https://invent.kde.org/plasma/plasma-workspace/-/commit/242a9b7e79c04beeb99a0127c83a32bac1e4555e Git commit f389824cd9980bb1cd07241d92fcb6676d5fff8d by Ismael Asensio. Committed on 21/08/2023 at 17:12. Pushed by iasensio into branch 'master'. kcms/cursortheme: Fix highlight when hovering the preview The PreviewItem implements hover event filters, which by default are accepted and not propagated to their parent, breaking the hightlight on hover for the GridView. We can simply "ignore()" those events so they are propagated, but still fully functional. M +4 -1 kcms/cursortheme/xcursor/previewwidget.cpp https://invent.kde.org/plasma/plasma-workspace/-/commit/f389824cd9980bb1cd07241d92fcb6676d5fff8d This appears to be fixed in all grid view KCMs now. (In reply to Nate Graham from comment #6) > This appears to be fixed in all grid view KCMs now. Is it fixed for elements that aren't on a grid? Like these ones in the original description: >On the Desktop Effects page, only the description gets bold on mouse hover. On pages without descriptions for list items like Virtual Desktops, Activities, and Window Rules there's no visible highlight anymore compared to Plasma 5. The last time I tried with Neon Unstable the issue in those pages was still present. Sorry, I missed that part. I can reproduce that issue in the Desktop Effects KCM, which likely has a different root cause. Let's track that separately in Bug 473997. The lack of hover highlights in other KCMs is intentional at this point, since there's nothing you can do with them when they're selected. |