Bug 472865

Summary:	Lift/Gamma/Gain effect is doing some weird stuff while adjusting the sliders
Product:	[Applications] kdenlive	Reporter:	rjs205 <robjamespogi>
Component:	Video Effects & Transitions	Assignee:	Jean-Baptiste Mardelle <jb>
Status:	RESOLVED FIXED
Severity:	normal	CC:	diekuhrannte
Priority:	NOR
Version First Reported In:	git-master
Target Milestone:	---
Platform:	Microsoft Windows
OS:	Microsoft Windows
Latest Commit:	https://invent.kde.org/multimedia/kdenlive/-/commit/79dae6dcd0c81d94956aa58b17fde752cc121eb3	Version Fixed/Implemented In:
Sentry Crash Report:
Attachments:	Video of the bug in action

Description rjs205 2023-08-01 06:20:42 UTC

SUMMARY
***
NOTE: If you are reporting a crash, please try to attach a backtrace with debug symbols.
See https://community.kde.org/Guidelines_and_HOWTOs/Debugging/How_to_create_useful_crash_reports
***


STEPS TO REPRODUCE
1.  Add any video clip to the timeline
2.  Add the effect
3.  Adjust the sliders

OBSERVED RESULT
The color wheels should act weirdly. (Random colors and whatnot).

EXPECTED RESULT
Your video should look funny thanks to the bug that is interfering with your color grade/correction.


SOFTWARE/OS VERSIONS
Windows: 11
macOS: 
Linux/KDE Plasma: 
(available in About System)
KDE Plasma Version: 
KDE Frameworks Version: 
Qt Version: 

ADDITIONAL INFORMATION

Comment 1 rjs205 2023-08-01 06:24:56 UTC

Created attachment 160660 [details]
Video of the bug in action

Comment 2 diekuhrannte@web.de 2023-08-31 19:54:31 UTC

Yes, it is a known bug - and should be solved with 23.08.0 - but unfortunately it is still not.
The problem occurs when the sliders have already been changed, then the "reset effect" was made. After that, the slider only causes the image to turn light-yellow or dark-blue.
Look here: https://bugs.kde.org/show_bug.cgi?id=436762

Comment 3 Jean-Baptiste Mardelle 2023-09-25 16:40:43 UTC

Git commit 48515473d3d2d3b193dee7342585be9ae13fee66 by Jean-Baptiste Mardelle.
Committed on 25/09/2023 at 18:40.
Pushed by mardelle into branch 'master'.

Fix multiple issues with Lift/Gamma/Gain undo
Related: bug 462406

M  +2    -2    src/assets/keyframes/model/keyframemodel.cpp
M  +2    -1    src/assets/keyframes/model/keyframemodel.hpp
M  +17   -0    src/assets/keyframes/model/keyframemodellist.cpp
M  +9    -1    src/assets/keyframes/model/keyframemodellist.hpp
M  +61   -0    src/assets/model/assetcommand.cpp
M  +23   -0    src/assets/model/assetcommand.hpp
M  +38   -19   src/assets/view/widgets/colorwheel.cpp
M  +4    -3    src/assets/view/widgets/colorwheel.h
M  +13   -13   src/assets/view/widgets/keyframewidget.cpp
M  +13   -7    src/assets/view/widgets/lumaliftgainparam.cpp
M  +4    -4    src/assets/view/widgets/lumaliftgainparam.hpp
M  +10   -0    src/utils/qcolorutils.cpp
M  +3    -0    src/utils/qcolorutils.h

https://invent.kde.org/multimedia/kdenlive/-/commit/48515473d3d2d3b193dee7342585be9ae13fee66

Comment 4 Jean-Baptiste Mardelle 2023-10-03 13:23:59 UTC

Git commit 79dae6dcd0c81d94956aa58b17fde752cc121eb3 by Jean-Baptiste Mardelle.
Committed on 03/10/2023 at 11:27.
Pushed by mardelle into branch 'release/23.08'.

Fix multiple issues with Lift/Gamma/Gain undo
Related: bug 462406

M  +2    -2    src/assets/keyframes/model/keyframemodel.cpp
M  +2    -1    src/assets/keyframes/model/keyframemodel.hpp
M  +17   -0    src/assets/keyframes/model/keyframemodellist.cpp
M  +9    -1    src/assets/keyframes/model/keyframemodellist.hpp
M  +61   -0    src/assets/model/assetcommand.cpp
M  +23   -0    src/assets/model/assetcommand.hpp
M  +38   -19   src/assets/view/widgets/colorwheel.cpp
M  +4    -3    src/assets/view/widgets/colorwheel.h
M  +13   -13   src/assets/view/widgets/keyframewidget.cpp
M  +13   -7    src/assets/view/widgets/lumaliftgainparam.cpp
M  +4    -4    src/assets/view/widgets/lumaliftgainparam.hpp
M  +10   -0    src/utils/qcolorutils.cpp
M  +3    -0    src/utils/qcolorutils.h

https://invent.kde.org/multimedia/kdenlive/-/commit/79dae6dcd0c81d94956aa58b17fde752cc121eb3