Bug 472512

Summary: Remove Stack and Global Blocks from debuginfo handling.
Product: [Developer tools] valgrind Reporter: Mark Wielaard <mark>
Component: sgcheckAssignee: Mark Wielaard <mark>
Status: ASSIGNED ---    
Severity: normal CC: amerey
Priority: NOR    
Version First Reported In: 3.21.0   
Target Milestone: ---   
Platform: Other   
OS: Linux   
Latest Commit: Version Fixed In:
Sentry Crash Report:
Attachments: Remove Stack and Global Blocks from debuginfo handling.

Description Mark Wielaard 2023-07-22 21:32:15 UTC
Created attachment 160455 [details]
Remove Stack and Global Blocks from debuginfo handling.

The VG_(di_get_stack_blocks_at_ip) and
VG_(di_get_global_blocks_from_dihandle) functions
were only used by the exp-sgcheck tool.
    
Since this tool was removed a couple of years back this code hasn't
been used or tested. Lets remove it to reduce the complexity of
dealing with debuginfo.
Comment 1 Mark Wielaard 2023-07-22 21:35:57 UTC
I wrote this while trying to understand https://bugs.kde.org/show_bug.cgi?id=471807
This code confused me till I realized it isn't actually used (and was last changed in 2008).
So I think it is best to just remove it so it doesn't confuse others.