| Summary: | Icons are changing positions after some time | ||
|---|---|---|---|
| Product: | [Plasma] plasmashell | Reporter: | hagioss <kontakt> |
| Component: | Desktop icons & Folder View widget | Assignee: | Plasma Bugs List <plasma-bugs-null> |
| Status: | RESOLVED FIXED | ||
| Severity: | normal | CC: | hein, kdedev, nate |
| Priority: | NOR | ||
| Version First Reported In: | 5.27.5 | ||
| Target Milestone: | 1.0 | ||
| Platform: | Debian stable | ||
| OS: | Linux | ||
| See Also: |
https://bugs.kde.org/show_bug.cgi?id=490891 https://bugs.kde.org/show_bug.cgi?id=468546 |
||
| Latest Commit: | https://invent.kde.org/plasma/plasma-desktop/-/commit/cc44615b34dacc2a4acfdc82de885c943318a7f6 | Version Fixed/Implemented In: | 6.3.0 |
| Sentry Crash Report: | |||
|
Description
hagioss
2023-07-10 15:45:43 UTC
This seems related to https://bugs.kde.org/show_bug.cgi?id=468546, where the cause is connecting / disconnecting displays Git commit cc44615b34dacc2a4acfdc82de885c943318a7f6 by Akseli Lahtinen.
Committed on 06/11/2024 at 16:30.
Pushed by akselmo into branch 'master'.
Refactor icon positioner saving and loading
The icon positioner saving and loading is handled by QML, which makes it a bit difficult
to work with the logic in positioner CPP files.
This change does the following:
- Explicitly save only on user interactions
- Moved the save and load of config to positioner.cpp
- Easier debugging of the saving and loading functions
- Still uses the JSON style of save/loading like the old one
- Technically should be compatible with the old config, which was also JSON.
- Makes positionerApplet accessible from FolderView qml
- Various checks for checking if screen is enabled or not to avoid doing unnecessary work when screen is off
- A lot of fixes to avoid any racing conditions
- Removed any timers
- Added various unit tests
Alternative to https://invent.kde.org/plasma/plasma-desktop/-/merge_requests/2603
Related: bug 482875, bug 494874, bug 433867, bug 494412, bug 468619, bug 449069, bug 495047, bug 453314
FIXED-IN: 6.3.0
M +1 -1 containments/desktop/package/contents/ui/FolderView.qml
M +1 -48 containments/desktop/package/contents/ui/FolderViewLayer.qml
M +165 -26 containments/desktop/plugins/folder/autotests/positionertest.cpp
M +18 -3 containments/desktop/plugins/folder/autotests/positionertest.h
M +23 -7 containments/desktop/plugins/folder/foldermodel.cpp
M +5 -0 containments/desktop/plugins/folder/foldermodel.h
M +176 -60 containments/desktop/plugins/folder/positioner.cpp
M +37 -8 containments/desktop/plugins/folder/positioner.h
https://invent.kde.org/plasma/plasma-desktop/-/commit/cc44615b34dacc2a4acfdc82de885c943318a7f6
|