| Summary: | When in Rectangular Region mode, ESC key should exit that mode and show the viewer window or "take new screenshot" window rather than quitting Spectacle | ||
|---|---|---|---|
| Product: | [Applications] Spectacle | Reporter: | jonzn4SUSE <jonzn4suse> |
| Component: | General | Assignee: | Noah Davis <noahadvs> |
| Status: | RESOLVED FIXED | ||
| Severity: | wishlist | CC: | josh, kde, nate |
| Priority: | NOR | ||
| Version: | 23.04.1 | ||
| Target Milestone: | --- | ||
| Platform: | Other | ||
| OS: | Linux | ||
| Latest Commit: | https://invent.kde.org/graphics/spectacle/-/commit/7999bc921fcf9e04fe5a5d0d3306de7ffe1de278 | Version Fixed In: | 24.02 |
| Sentry Crash Report: | |||
|
Description
jonzn4SUSE
2023-05-27 05:05:25 UTC
I do see this bug, but I'll let you guys make the decision. https://bugs.kde.org/show_bug.cgi?id=456823 I just noticed in Leap 15.4 that Spectacle 21.12.3 also closes when hitting the ESC key. This is intentional behavior, but beginning with Spectacle 23.04 this behavior is improved because taking a screenshot has been redone. Taking a rectangular screenshot for example doesn't block every other action, you can simply switch to another mode. When I hit Rectangular Region and then change my mind, the ESC key is the only option to get out of that mode. After hitting ESC, the app is closed. In the previous version it would just take me out of the Rectangular Region mode and back to the app without having to reopen it. (In reply to jonzn4SUSE from comment #4) > When I hit Rectangular Region and then change my mind, the ESC key is the > only option to get out of that mode. After hitting ESC, the app is closed. > In the previous version it would just take me out of the Rectangular Region > mode and back to the app without having to reopen it. To be clear, do you only expect it to return when starting spectacle from the viewer window or new screenshot dialog or do you expect it to return to the viewer window/new screenshot dialog even when starting in rectangle capture mode? I was planning to eventually make Spectacle return to the viewer window/new screenshot dialog after pressing escape in rectangle capture mode if spectacle was started with the viewer window/new screenshot dialog. (In reply to Noah Davis from comment #5) > (In reply to jonzn4SUSE from comment #4) > > When I hit Rectangular Region and then change my mind, the ESC key is the > > only option to get out of that mode. After hitting ESC, the app is closed. > > In the previous version it would just take me out of the Rectangular Region > > mode and back to the app without having to reopen it. > > To be clear, do you only expect it to return when starting spectacle from > the viewer window or new screenshot dialog or do you expect it to return to > the viewer window/new screenshot dialog even when starting in rectangle > capture mode? I was planning to eventually make Spectacle return to the > viewer window/new screenshot dialog after pressing escape in rectangle > capture mode if spectacle was started with the viewer window/new screenshot > dialog. Here is the video showing how the app worked before the current version when hitting the escape key. https://youtu.be/4qinOwGmbr4 Re-titling and re-opening to reflect the request, which seems reasonable given that it's a behavioral change from the older version of Spectacle. Marking it as a wishlist though, as it's not technically a bug but rather a request to change the current design. But the request seems reasonable to me. Very reasonable... Agreed - I too have grown to expect ESC to back out of current action, not close the whole application. A possibly relevant merge request was started @ https://invent.kde.org/graphics/spectacle/-/merge_requests/301 Git commit 7999bc921fcf9e04fe5a5d0d3306de7ffe1de278 by Noah Davis. Committed on 30/11/2023 at 14:44. Pushed by ndavis into branch 'master'. Go back to viewer when pressing Escape in a capture window in GUI mode Note, this does not bring back the previous screenshot. Whatever was in the capture window will end up in the viewer window. Bringing back the previous screenshot would require a lot more work than this, so we'll have do that later. M +1 -5 src/Gui/SpectacleWindow.cpp M +5 -0 src/SpectacleCore.cpp https://invent.kde.org/graphics/spectacle/-/commit/7999bc921fcf9e04fe5a5d0d3306de7ffe1de278 Resolved... I open the app and hit ESC, the app still closes. This wasn't an issue until the update. I know it doesn't bring back the screenshot, I'm trying to get the app to stay open whenever I hit the ESC key. That's it. I can install an older version openSUSE and post a video if needed. The fix was just merged an hour ago, and will be included in the upcoming Spectacle 24.02 version, scheduled to be released on February 28th of next year. Disregard last comment. I do see that it's working in openSUSE Leap 15.6. I'll test Tumble when I get home. Thanks ;-)) Wish we could edit or delete comments on this site. ;-)) I'm on openSUSE Leap 15.6 Alpha and it's running version 22.12.3. I'm hoping you're going to bring back the same behavior as this version. (In reply to jonzn4SUSE from comment #16) > I'm on openSUSE Leap 15.6 Alpha and it's running version 22.12.3. I'm > hoping you're going to bring back the same behavior as this version. This was fixed in 24.02. 22.12 is now unsupported. |