| Summary: | Cannot change laptop display brightness when connected to external monitor with ddcutil support | ||
|---|---|---|---|
| Product: | [Plasma] Powerdevil | Reporter: | quangngo <ngoquang2708> |
| Component: | general | Assignee: | Plasma Bugs List <plasma-bugs> |
| Status: | RESOLVED FIXED | ||
| Severity: | major | CC: | albertvaka, aleixpol, hockeymikey, me, me, natalie_clarius, nate, postix |
| Priority: | NOR | ||
| Version: | 5.27.5 | ||
| Target Milestone: | --- | ||
| Platform: | Arch Linux | ||
| OS: | Linux | ||
| URL: | https://bugs.archlinux.org/task/78536 | ||
| Latest Commit: | https://invent.kde.org/plasma/powerdevil/-/commit/caf26c7d2842b3e81e370f414e859609d2fa607b | Version Fixed In: | 5.27.6 |
| Sentry Crash Report: | |||
|
Description
quangngo
2023-05-17 14:37:21 UTC
Packaging problem, already reported as https://bugs.archlinux.org/task/78536 It's not a downstream issue for a distro to enable our feature and that feature is broken. Distros can certainly disable it again, but it's on us to fix it. They keep telling "that this is no longer considered experimental and is enabled by default for Plasma 6". I don't know who said that, and I'd like to have a word with that person. Also, passing an otherwise disabled by default configuration flag certainly does not strike me as "enabled by default". It was enabled by default here in KDE in https://invent.kde.org/plasma/powerdevil/-/commit/e4a5e5d3e017ef45979933e14e47408bb3a59dda I create a merge request here https://invent.kde.org/plasma/powerdevil/-/merge_requests/178. Can someone test this. *** This bug has been marked as a duplicate of bug 449263 *** I'm the one who enabled compiling with libddc by default. I think it's a great feature to be able to control your monitor brightness from Plasma instead of having to use the wonky built-in buttons, and would be nice to polish this feature before Plasma 6. Maybe it can be one of the "cool new things" for marketing. I also told Antonio, the Arch packager, that it was ready to enable in Plasma 5 even if it was not on by default. I didn't know that powerdevil could only use one backend though, and that enabling libddc would mean the laptop brightness control would be effectively disabled. Thanks quagngo for the fix where the laptop brightness backend takes precedence, I'll give a review now. The best fix however would be for both backends to be active at the same time, and for Plasma to show two sliders. It would be awesome if we can get that for Plasma 6. Related issue about supporting multiple brightness backends: https://invent.kde.org/plasma/powerdevil/-/issues/19 *** Bug 449263 has been marked as a duplicate of this bug. *** Git commit ddcabaf93712b953e3ec327416e0332d7e44fc40 by Albert Vaca Cintora, on behalf of Quang Ngô. Committed on 31/05/2023 at 11:24. Pushed by albertvaka into branch 'Plasma/5.27'. Fix ddcutil for laptop user This will prioritize usage of backlight helper over ddcutil. If backlight helper fail, fall back to ddcutil. Expected result: * Laptop users can now change the brightness of the internal display. External display will use its own controls. * Does not affect desktop users. M +71 -76 daemon/backends/upower/powerdevilupowerbackend.cpp https://invent.kde.org/plasma/powerdevil/-/commit/ddcabaf93712b953e3ec327416e0332d7e44fc40 Git commit caf26c7d2842b3e81e370f414e859609d2fa607b by Nate Graham, on behalf of Quang Ngô. Committed on 31/05/2023 at 17:16. Pushed by ngraham into branch 'master'. Fix ddcutil for laptop user This will prioritize usage of backlight helper over ddcutil. If backlight helper fail, fall back to ddcutil. Expected result: * Laptop users can now change the brightness of the internal display. External display will use its own controls. * Does not affect desktop users. (cherry picked from commit ddcabaf93712b953e3ec327416e0332d7e44fc40) M +71 -76 daemon/backends/upower/powerdevilupowerbackend.cpp https://invent.kde.org/plasma/powerdevil/-/commit/caf26c7d2842b3e81e370f414e859609d2fa607b |