Bug 469371

Summary:	Easy "rectangular highlight" annotation
Product:	[Applications] Spectacle	Reporter:	Jay Tuckey <jay>
Component:	General	Assignee:	Noah Davis <noahadvs>
Status:	CONFIRMED ---
Severity:	wishlist	CC:	edio, kde, kdebugs, nate
Priority:	NOR
Version First Reported In:	23.04.0
Target Milestone:	---
Platform:	Neon
OS:	Linux
Latest Commit:		Version Fixed/Implemented In:
Sentry Crash Report:

Description Jay Tuckey 2023-05-05 01:03:54 UTC

When taking screenshots I like to use the highlighter in rectangle mode to make markings - this used to be a feature in the previous version of spectacle but now is missing.

Overall the latest update is pretty nice, but seems to have lost a couple features. I've also run into this issue:
https://bugs.kde.org/show_bug.cgi?id=468077

STEPS TO REPRODUCE
1. Take a screenshot
2. Click "Show Annotation Tools"
3. Select "Highlighter". This tool used to be called "Marker Pen" and had three modes - "Marker Pen", "Marker Rectangle", and "Marker Ellipse". 
4. These tools still exist in Gwenview if you use the "Annotate" button, but not in Spectacle.

OBSERVED RESULT
"Marker Rectangle"/"Highlighter Rectangle" is missing

EXPECTED RESULT
These tools should be there.

SOFTWARE/OS VERSIONS
Operating System: KDE neon 5.27
KDE Plasma Version: 5.27.4
KDE Frameworks Version: 5.105.0
Qt Version: 5.15.9
Kernel Version: 5.19.0-41-generic (64-bit)
Graphics Platform: Wayland
Processors: 8 × Intel® Core™ i7-10510U CPU @ 1.80GHz
Memory: 15.4 GiB of RAM
Graphics Processor: Mesa Intel® UHD Graphics
Manufacturer: LENOVO
Product Name: 20S6S01X00
System Version: ThinkPad T15 Gen 1

Comment 1 Nate Graham 2023-05-16 20:29:15 UTC

You can draw a rectangle with a transparent color as a workaround. Not as easy, but it can be done.

Comment 2 Noah Davis 2023-05-16 21:04:39 UTC

It's worth noting that the highlight effect's rendering is different from painting a semi-transparent object over something else. It uses 
QPainter::CompositionMode_Darken (the darker of the source and destination colors is selected).

Comment 3 Nate Graham 2023-05-31 18:50:18 UTC

*** Bug 470317 has been marked as a duplicate of this bug. ***

Comment 4 Bug Janitor Service 2025-01-16 22:49:53 UTC

A possibly relevant merge request was started @ https://invent.kde.org/graphics/spectacle/-/merge_requests/433

Comment 5 Bug Janitor Service 2025-01-16 22:49:54 UTC

A possibly relevant merge request was started @ https://invent.kde.org/graphics/spectacle/-/merge_requests/433

Comment 6 Noah Davis 2025-01-17 16:23:48 UTC

Git commit f5434a1c25975aafcacffd7d6b58ef25ce8743a6 by Noah Davis.
Committed on 16/01/2025 at 22:48.
Pushed by ndavis into branch 'master'.

Allow snapping Freehand and Highlighter tools to straight lines with Shift
Related: bug 498327

Doesn't fix the lack of a true rectangle highlighter, but should make it easier to highlight rectangular areas when combined with increasing the stroke size.

M  +14   -5    src/Gui/Annotations/AnnotationDocument.cpp
M  +1    -1    src/Gui/Annotations/AnnotationDocument.h
M  +1    -1    src/Gui/Annotations/AnnotationViewport.cpp

https://invent.kde.org/graphics/spectacle/-/commit/f5434a1c25975aafcacffd7d6b58ef25ce8743a6

Comment 7 Noah Davis 2025-01-17 16:23:50 UTC

Git commit d397e2abae710ec4cd00d8543e4779f982d524b1 by Noah Davis.
Committed on 16/01/2025 at 22:52.
Pushed by ndavis into branch 'master'.

Use flat caps when snapping a 2 point highlighter line

We don't flatten/sharpen the caps and joins of highlighter lines with multiple points because they would look terrible.

M  +7    -1    src/Gui/Annotations/AnnotationDocument.cpp

https://invent.kde.org/graphics/spectacle/-/commit/d397e2abae710ec4cd00d8543e4779f982d524b1