Summary: | Cannot enter characters with `ALT GR` modifier key while renaming layers (keys combination is captured by shortcuts) | ||
---|---|---|---|
Product: | [Applications] krita | Reporter: | Aurélien Da Campo <aurelien.dacampo> |
Component: | Shortcuts and Canvas Input Settings | Assignee: | Dmitry Kazakov <dimula73> |
Status: | RESOLVED FIXED | ||
Severity: | normal | CC: | andreas, dimula73, grum999, halla |
Priority: | NOR | ||
Version: | 5.1.4 | ||
Target Milestone: | --- | ||
Platform: | Microsoft Windows | ||
OS: | Microsoft Windows | ||
Latest Commit: | https://invent.kde.org/graphics/krita/-/commit/d09b21a09b6d722fe5be6e1a235f7085dbfdca7a | Version Fixed In: |
Description
Aurélien Da Campo
2023-04-16 11:31:13 UTC
Hi! Can you add those characters * when the layerbox is undocked? * the search field in the brush presets docker? (In reply to Halla Rempt from comment #1) > Hi! > > Can you add those characters > > * when the layerbox is undocked? > * the search field in the brush presets docker? Hi, Thanks for taking the time to investigate this issue :) Here are few answers to your questions: 1) The behavior is the same when the layer box is docked or undocked 2) The behavior is the same when in the brush presets search box I noticed something new, I can enter few of the characters on Vector Layers. This really seems to be linked to the capture of shortcuts by the current context. When being in the context of a Paint Layer, the character input is captured by the shortcuts of the painting tool. For example, if I try to enter the character `[` with the shortcut `ALTGR` + `[` I see callout showing that the Brush Size has been reduced but no characters are entered in the input field. That's interesting, and makes it more probable that this is a bug we can fix, instead of a misfeature in Qt. I've added this issue to the bugs to discuss in next Monday's team meeting: https://docs.google.com/document/d/1JOZly_nL-oAORpwbEx3wdyuhomz-I2CGZT67RztosPA/edit# Well, yes, we have some special code that maps AltGr to something else on Windows to make sure it works as a shortcut... We need to look into that, especially, why KisInputManager interferes with the input boxes. Hi, Aurélien! Could you please test this package? https://disk.yandex.ru/d/GG6GsAEc_UZ7wg I have tested these testcases and they work fine with the following testcases: 1) Rename a layer 2) Add/Edit a layers filter (in a popup) 3) Add/Edit a brush preset filter 4) Add new brush preset tag (in a popup) I have tested that in US-Intl-AltGr layout. Could you test that with French layout? Hi Can't test it for now, but could the problem of bug https://bugs.kde.org/show_bug.cgi?id=469691 is related with this one? Grum999 A possibly relevant merge request was started @ https://invent.kde.org/graphics/krita/-/merge_requests/1807 Aurélien, could you please test Dmitry's package? I just tested the provided build (5.2.0-prealpha (git a92c1c6)) and the issue is still present with the same symptoms. Hi, Aurélien! Could you please make a video recording of the screen with the problem? I have installed French layout into my system and I could type [] and {} perfectly fine with AltGr on my system... Hi Dmitry! Here is the shot - I even managed to reproduce it with the Windows On-Screen Keyboard: https://www.swisstransfer.com/d/1cb99891-2ca7-4d59-a8d7-1b979c050635 Thank you! I will recheck a bit later today Git commit 45a9469f0f2d0fc8f654247a5593032fa600a0d5 by Dmitry Kazakov. Committed on 21/06/2023 at 16:11. Pushed by dkazakov into branch 'master'. Fix typing symbols with AltGr key on Windows We need to pass an environment variable to Qt to make sure Qt detects AltGr key as Qt::GroupSwitchModifier M +4 -0 krita/main.cc https://invent.kde.org/graphics/krita/-/commit/45a9469f0f2d0fc8f654247a5593032fa600a0d5 Git commit d09b21a09b6d722fe5be6e1a235f7085dbfdca7a by Dmitry Kazakov. Committed on 22/06/2023 at 09:56. Pushed by dkazakov into branch 'master'. Fix Layer Filter and Add Tag menues from being closed when AltGr is pressed QMenu has a spcial handler for Alt key to handle &-style mnemonics, so we need to explicitly disable that for our custom menues that have input boxes inside. M +5 -1 libs/resourcewidgets/KisTagToolButton.cpp M +1 -0 libs/widgetutils/CMakeLists.txt A +20 -0 libs/widgetutils/KisMenuStyleDontCloseOnAlt.cpp [License: GPL(v2.0+)] A +26 -0 libs/widgetutils/KisMenuStyleDontCloseOnAlt.h [License: GPL(v2.0+)] M +6 -1 plugins/dockers/layerdocker/LayerBox.cpp https://invent.kde.org/graphics/krita/-/commit/d09b21a09b6d722fe5be6e1a235f7085dbfdca7a *** Bug 446038 has been marked as a duplicate of this bug. *** |