Summary: | Inconsistent drag-from-empty-areas-of-toolbar behavior in Discover | ||
---|---|---|---|
Product: | [Frameworks and Libraries] frameworks-kirigami | Reporter: | Connor Carney <kbugs> |
Component: | general | Assignee: | kdelibs bugs <kdelibs-bugs> |
Status: | RESOLVED FIXED | ||
Severity: | normal | CC: | aleixpol, me, nate, notmart |
Priority: | NOR | ||
Version: | 5.104.0 | ||
Target Milestone: | Not decided | ||
Platform: | Compiled Sources | ||
OS: | Linux | ||
Latest Commit: | https://invent.kde.org/frameworks/kirigami/commit/ca527f2b8aa98987e9235633d68480ed68eb77e3 | Version Fixed In: | 5.105 |
Attachments: | list vs layout toolbar behavior |
Description
Connor Carney
2023-03-27 18:44:58 UTC
Discover doesn't have a toolbar though. Moving to Kirigami as it's responsible for the component you are referring to. That header bar on top under the titlebar is the toolbar. I can reproduce the fact that on some pages it's draggable, and on some pages it's not. This suggests that it may actually be an implementation issue in Discover rather than a general problem in Kirigami. That said, I can't find a pattern here: Draggable-toolbar pages: - Home/Featured - App details - About Non-draggable-toolbar pages: - Apps list/Search results - Installed - Settings - Updates Created attachment 157857 [details]
list vs layout toolbar behavior
I think that the pattern there is something like "pages where the main item is a ListView" which I can reproduce with this minimal example.
A possibly relevant merge request was started @ https://invent.kde.org/frameworks/kirigami/-/merge_requests/1021 Git commit dc4f730a80a087d32c63d4af23ae4e66a7bec62a by Marco Martin. Committed on 05/04/2023 at 10:05. Pushed by mart into branch 'master'. fix dragging from toolbar scrollingArea, the main child of the contentitem when not in itemview mode, was haging invisible over the toolbar when in itemview mode, making it eat mouse events M +2 -0 src/controls/ScrollablePage.qml https://invent.kde.org/frameworks/kirigami/commit/dc4f730a80a087d32c63d4af23ae4e66a7bec62a Git commit ca527f2b8aa98987e9235633d68480ed68eb77e3 by Marco Martin. Committed on 05/04/2023 at 10:07. Pushed by mart into branch 'kf5'. fix dragging from toolbar scrollingArea, the main child of the contentitem when not in itemview mode, was haging invisible over the toolbar when in itemview mode, making it eat mouse events M +2 -0 src/controls/ScrollablePage.qml https://invent.kde.org/frameworks/kirigami/commit/ca527f2b8aa98987e9235633d68480ed68eb77e3 |