Bug 467709

Summary:	[Wayland] Hovering over task icons with disabled previews still spikes up wireplumber cpu usage
Product:	[Plasma] plasmashell	Reporter:	serfreeman1337 <serfreeman1337>
Component:	Task Manager and Icons-Only Task Manager	Assignee:	Plasma Bugs List <plasma-bugs>
Status:	RESOLVED FIXED
Severity:	normal	CC:	nate, sam
Priority:	NOR
Version:	5.27.3
Target Milestone:	1.0
Platform:	Arch Linux
OS:	Linux
Latest Commit:	https://invent.kde.org/plasma/plasma-desktop/commit/df86cb8d805a38d1cedc29142541530954b89682	Version Fixed In:	5.27.4
Sentry Crash Report:

Description serfreeman1337 2023-03-23 06:55:57 UTC

STEPS TO REPRODUCE
1. Uncheck "Show small window previews when hovering over Tasks".
2. Open htop or any other tool to monitor CPU usage.
3. Quickly move cursor between task icons.

OBSERVED RESULT
Wireplumber spikes up cpu usage even though there is no reason to use it, since window previews are disabled.

EXPECTED RESULT
Moving cursor over icons should not use wireplumber if window previews are disabled. 

SOFTWARE/OS VERSIONS
KDE Frameworks Version: 5.104.0
Qt Version: 5.15.8

ADDITIONAL INFORMATION
The reason I wanted to disable window previews is because they make wireplumber to spam logs:
<WpSiStandardLink:0x55df35f9fc80> si-standard-link: in/out items are not valid anymore
<WpSiNode:0x55df35f6a140> Object activation aborted: proxy destroyed
<WpSiStandardLink:0x55df35f69830> 1 of 1 PipeWire links failed to activate

Comment 1 Bug Janitor Service 2023-03-25 02:48:17 UTC

A possibly relevant merge request was started @ https://invent.kde.org/plasma/plasma-desktop/-/merge_requests/1445

Comment 2 Fushan Wen 2023-03-26 13:55:26 UTC

Git commit 47edbf51e4e68279944670df3fce86a9d11c4273 by Fushan Wen.
Committed on 26/03/2023 at 13:49.
Pushed by fusionfuture into branch 'Plasma/5.27'.

applets/taskmanager: skip updating tooltip when it's disabled

If task tooltips are disabled, the main item bindings should not be
updated when mouse is over any task unless it's clicked by the user.
Related: bug 452187
FIXED-IN: 5.27.4

M  +2    -2    applets/taskmanager/package/contents/ui/Task.qml
M  +1    -1    applets/taskmanager/package/contents/ui/code/tools.js
M  +0    -9    applets/taskmanager/package/contents/ui/main.qml

https://invent.kde.org/plasma/plasma-desktop/commit/47edbf51e4e68279944670df3fce86a9d11c4273

Comment 3 Méven Car 2023-04-01 16:24:14 UTC

Git commit df86cb8d805a38d1cedc29142541530954b89682 by Méven Car, on behalf of Fushan Wen.
Committed on 01/04/2023 at 16:18.
Pushed by meven into branch 'master'.

applets/taskmanager: skip updating tooltip when it's disabled

If task tooltips are disabled, the main item bindings should not be
updated when mouse is over any task unless it's clicked by the user.
Related: bug 452187
FIXED-IN: 5.27.4


(cherry picked from commit 47edbf51e4e68279944670df3fce86a9d11c4273)

M  +2    -2    applets/taskmanager/package/contents/ui/Task.qml
M  +1    -1    applets/taskmanager/package/contents/ui/code/tools.js
M  +0    -9    applets/taskmanager/package/contents/ui/main.qml

https://invent.kde.org/plasma/plasma-desktop/commit/df86cb8d805a38d1cedc29142541530954b89682

Comment 4 Fushan Wen 2023-04-05 14:49:57 UTC

Git commit 7195637d184c146e177feb28fe904cbf98a0a87e by Fushan Wen.
Committed on 05/04/2023 at 14:47.
Pushed by fusionfuture into branch 'Plasma/5.27'.

applets/taskmanager: reset `parentTask` after a task was moved

After a task item was moved, the property bindings in openWindowToolTipDelegate
also need updated, but to fix bug 467709, `mainItem.parentTask === task`
was added, which causes empty tooltips after a task item was moved.

Test plan:

1. Disable task tooltips and enable Click to open small tooltips
2. Open some Konsole windows to create a task group
3. Open Firefox or any other app
4. Click the Konsole group to activate the tooltip
5. Move Konsole group's position
6. Click the Konsole group again. Before this change the tooltip is
   empty. After this change the tooltip has contents.

Amends 47edbf51e4e68279944670df3fce86a9d11c4273
Related: bug 452187
FIXED-IN: 5.27.5

M  +1    -0    applets/taskmanager/package/contents/ui/MouseHandler.qml
M  +2    -0    applets/taskmanager/package/contents/ui/Task.qml

https://invent.kde.org/plasma/plasma-desktop/commit/7195637d184c146e177feb28fe904cbf98a0a87e

Comment 5 Fushan Wen 2023-04-05 14:52:12 UTC

Git commit 015ad951fc3473ff05c966c350b8ec847606e9e0 by Fushan Wen.
Committed on 05/04/2023 at 14:51.
Pushed by fusionfuture into branch 'master'.

applets/taskmanager: reset `parentTask` after a task was moved

After a task item was moved, the property bindings in openWindowToolTipDelegate
also need updated, but to fix bug 467709, `mainItem.parentTask === task`
was added, which causes empty tooltips after a task item was moved.

Test plan:

1. Disable task tooltips and enable Click to open small tooltips
2. Open some Konsole windows to create a task group
3. Open Firefox or any other app
4. Click the Konsole group to activate the tooltip
5. Move Konsole group's position
6. Click the Konsole group again. Before this change the tooltip is
   empty. After this change the tooltip has contents.

Amends 47edbf51e4e68279944670df3fce86a9d11c4273
Related: bug 452187
FIXED-IN: 5.27.5


(cherry picked from commit 7195637d184c146e177feb28fe904cbf98a0a87e)

M  +1    -0    applets/taskmanager/package/contents/ui/MouseHandler.qml
M  +2    -0    applets/taskmanager/package/contents/ui/Task.qml

https://invent.kde.org/plasma/plasma-desktop/commit/015ad951fc3473ff05c966c350b8ec847606e9e0