Summary: | When using the app in a non-English language, cover overlay "Play" and "Add to Playlist" buttons do not work on startup until you switch to a different page and back | ||
---|---|---|---|
Product: | [Applications] Elisa | Reporter: | Emir SARI <emir_sari> |
Component: | general | Assignee: | Matthieu Gallien <matthieu_gallien> |
Status: | RESOLVED FIXED | ||
Severity: | normal | CC: | nate, pieterkristensen, xnagytibor |
Priority: | VHI | ||
Version: | 22.12.3 | ||
Target Milestone: | --- | ||
Platform: | Neon | ||
OS: | Linux | ||
Latest Commit: | https://invent.kde.org/multimedia/elisa/-/commit/6da2a89f35e0b36352baa458ec07011b5f5d8b73 | Version Fixed In: | 23.04 |
Attachments: | patch to add output for missing connection |
Description
Emir SARI
2023-03-14 17:27:32 UTC
They work for me. Are you using a non en_US language? If so, if you temporarily switch to en_US, do the buttons work? Yes, tr_TR. They indeed work when switched to en_US. Haven't tried with other English variants. I thought so. We've had issues like this before. I'll investigate at some point in the short to medium term. Even when running `en_GB elisa`, I can reproduce the bug. What's happening under the hood is that in abstractmediaproxymodel.cpp, the enqueue() signal is emitted but MediaPlayListProxyModel::enqueue is not connected to it, so nothing happens. However when running `en_US elisa`, the connection is made so MediaPlayListProxyModel::enqueue handles the signal and does what it needs to do. I have not yet figured out why the connection isn't getting made when using any locale other than en_US. ...I mean `LANG=en_GB elisa` and `LANG=en_US elisa`, of course. The weird thing is, when running with `LANG=en_GB` those buttons are only broken if you stay on the startup Albums/Artists page. When you switch away to a different page, then navigate right back those buttons start working as they should. Fascinating. Can confirm. Created attachment 157801 [details]
patch to add output for missing connection
I failed to reproduce even by running LANG=fr_FR ./elisa. I suspect this to be a weird timing issue. Would be nice to get someone to run with the patch and see if the added output shows up in the log. I can reproduce the issue with `LANG=fr_FR elisa`, but that patch produces no output for me (and info debug logging is enabled). A possibly relevant merge request was started @ https://invent.kde.org/multimedia/elisa/-/merge_requests/433 Fixed by Matthieu Gallien with https://invent.kde.org/multimedia/elisa/-/commit/6da2a89f35e0b36352baa458ec07011b5f5d8b73 in Elisa 23.04! *** Bug 454032 has been marked as a duplicate of this bug. *** |