| Summary: | Improvement: Current trackinfo not displayed when using a radio station | ||
|---|---|---|---|
| Product: | [Applications] Elisa | Reporter: | slartibart70 |
| Component: | general | Assignee: | Matthieu Gallien <matthieu_gallien> |
| Status: | RESOLVED DUPLICATE | ||
| Severity: | normal | CC: | jackhill3103, manuel.roth, sunny.bed7466 |
| Priority: | NOR | ||
| Version: | 22.12.3 | ||
| Target Milestone: | --- | ||
| Platform: | Fedora RPMs | ||
| OS: | Linux | ||
| Latest Commit: | Version Fixed In: | ||
| Sentry Crash Report: | |||
| Attachments: |
Questionable check, already commented out by me
Screenshot of Elisa with the check commented out - Meta info is shown |
||
|
Description
slartibart70
2023-03-13 08:31:49 UTC
A possibly relevant merge request was started @ https://invent.kde.org/multimedia/elisa/-/merge_requests/461 Created attachment 173294 [details]
Questionable check, already commented out by me
That the meta information of web radio is not shown is bugging me, too. I debugged and found a questionable check that I don't understand. If I remove that check, stream information are shown. Can this check be removed? Created attachment 173295 [details]
Screenshot of Elisa with the check commented out - Meta info is shown
A possibly relevant merge request was started @ https://invent.kde.org/multimedia/elisa/-/merge_requests/628 Git commit c0754bde50db970abe67fb4580ac033f6da4ecfa by Jack Hill, on behalf of Manuel Roth. Committed on 22/10/2024 at 18:38. Pushed by jackh into branch 'master'. Fix not showing metadata of webradio stream Currently when playing a webradio stream with VLC backend, metadata like station name, and artist - title are not shown. This is due to an unnecessary if-statement restricting changes only for MediaPlayList::ColumnsRoles::IsValidRole, CountRole and IsPlayingRole. The if statement can be safely removed because the following switch-case has a sensible default case. M +0 -4 src/mediaplaylist.cpp https://invent.kde.org/multimedia/elisa/-/commit/c0754bde50db970abe67fb4580ac033f6da4ecfa Git commit ddc51ffaea6a5cd93b70e322011c76104f0dfd04 by Jack Hill, on behalf of Manuel Roth. Committed on 22/10/2024 at 18:38. Pushed by jackh into branch 'master'. Fix artist/title/station metadata for vlc http streams The metadata of webradio streams contains several fields, sometimes with different usages. This code change aims to use Elisa's ColumnsRoles::ArtitestRole and ::TitleRole (song title) as good as possible. Only for libvlc backend. Developed against AAC(+), MP3 and also OGG streams. M +1 -1 src/audiowrapper.h M +17 -3 src/audiowrapper_libvlc.cpp M +2 -2 src/manageaudioplayer.cpp https://invent.kde.org/multimedia/elisa/-/commit/ddc51ffaea6a5cd93b70e322011c76104f0dfd04 *** This bug has been marked as a duplicate of bug 417895 *** A possibly relevant merge request was started @ https://invent.kde.org/multimedia/elisa/-/merge_requests/638 Git commit aa451081a5e4b4dd1bc9ce015aa566ec94b13127 by Jack Hill, on behalf of Manuel Roth. Committed on 03/11/2024 at 12:24. Pushed by jackh into branch 'master'. Using UTF-8 encoding for webradio stream metadata (VLC backend) Tested using the following radio stations: http://edge68.streamonkey.net/fho-hitradioohrlive/stream/ http://listen.radioking.com/radio/623869/stream/686722 M +6 -3 src/audiowrapper_libvlc.cpp https://invent.kde.org/multimedia/elisa/-/commit/aa451081a5e4b4dd1bc9ce015aa566ec94b13127 |