Summary: | KDE Partition Manager shows the partition name as label and doesn't allow you to change one | ||
---|---|---|---|
Product: | [Applications] partitionmanager | Reporter: | John <ilikefoss> |
Component: | general | Assignee: | Andrius Štikonas <andrius> |
Status: | RESOLVED FIXED | ||
Severity: | normal | CC: | ilikefoss, p.r.worrall |
Priority: | NOR | ||
Version First Reported In: | 22.12.3 | ||
Target Milestone: | --- | ||
Platform: | Debian unstable | ||
OS: | Linux | ||
Latest Commit: | Version Fixed In: | 23.08.0 | |
Sentry Crash Report: | |||
Attachments: | Partitions with names and labels set and a partition properties window opened |
Description
John
2023-03-07 06:21:48 UTC
Agree. GPT partitions have a "PartitionName" (https://uefi.org/specs/UEFI/2.10/05_GUID_Partition_Table_Format.html#gpt-partition-entry-array) Filesystems generally have a "Label" or "Volume Label" (man mkfs.btrfs, .ext4, etc.) Partition Manager should follow this terminology (In reply to Paul Worrall from comment #1) > Agree. > > GPT partitions have a "PartitionName" > (https://uefi.org/specs/UEFI/2.10/05_GUID_Partition_Table_Format.html#gpt- > partition-entry-array) > > Filesystems generally have a "Label" or "Volume Label" (man mkfs.btrfs, > .ext4, etc.) > > Partition Manager should follow this terminology There seems to be a bit of a mess with label vs name for partitions... Hmm, I think I followed terminology used by lsblk: $ lsblk -o PARTLABEL /dev/sda1 PARTLABEL EFI System lsblk is part of util-linux package. Yet fdisk which is also from util-linux uses Partition Name. I guess this confusion in therminology is because they are essentially the same thing, just at different levels, one is a string at partition level, the other at file system level. That said, if people feel strongly that this should be partition name, we can change it. Support for actually editing parition names is not wired into GUI (if I remember correctly kpmcore library has implemented required functions, but it's not exposed in GUI). Anyway, this is a duplicate of 443197, so any discussion for this point should be there. 1. Fixed 2. Fixed 3 This is already reported as 443197. 4 and 5 are kind of blocked by 3 (in any case best done together). I mentioned this bug in 443197, so I'll close this fixed even though 3 is not yet fixed. Git commit 6f88ec0124fa7da45cd0c479829a66f7ddd41296 by Andrius Štikonas. Committed on 12/03/2023 at 00:27. Pushed by stikonas into branch 'master'. Rename Partition Label to Partition Name M +1 -1 src/gui/partitionmanagerwidgetbase.ui M +1 -1 src/gui/partpropswidgetbase.ui https://invent.kde.org/system/partitionmanager/commit/6f88ec0124fa7da45cd0c479829a66f7ddd41296 |