Summary: | Plasma-welcome doesn't fit the screen on a PinePhone | ||
---|---|---|---|
Product: | [Applications] Welcome Center | Reporter: | kde <kde> |
Component: | general | Assignee: | Nate Graham <nate> |
Status: | RESOLVED FIXED | ||
Severity: | normal | CC: | kde, nate, ngompa13 |
Priority: | NOR | ||
Version: | unspecified | ||
Target Milestone: | --- | ||
Platform: | unspecified | ||
OS: | Linux | ||
Latest Commit: | https://invent.kde.org/plasma/plasma-welcome/commit/7913b8b3eb1d57cefd3a5b2cd44f0ec20cd92236 | Version Fixed In: | 6.0 |
Sentry Crash Report: |
Description
kde@warpspeed.dk
2023-02-28 00:23:06 UTC
Pinephone screen is 720x1440, with a default scale factor of 2x, which means an effective scaled resolution of 360x720. So we need to fix in that. Converting to GridUnits at the default font of Noto Sans 10pt (which results in an 18px GridUnit), this means a minimum size of 20x40 GridUnits. Working on this. A possibly relevant merge request was started @ https://invent.kde.org/plasma/plasma-welcome/-/merge_requests/69 Git commit 7913b8b3eb1d57cefd3a5b2cd44f0ec20cd92236 by Nate Graham. Committed on 05/03/2023 at 19:10. Pushed by ngraham into branch 'master'. Make the page layouts mobile-friendly This app was developed for a desktop use case, but people are running it on mobile devices too. Getting it in a better shape for that use case turns out to not be very hard--mostly a matter of replacing long row layouts with grid or column layouts, making graphics dynamically resize, reducing margins a bit, etc. This commit does not adapt the *content* for mobile use cases; for that, see https://invent.kde.org/plasma/plasma-welcome/-/issues/13. FIXED-IN: 6.0 M +- -- src/contents/assets/konqi-build.png M +- -- src/contents/assets/konqi-kde-hi.png M +5 -5 src/contents/ui/main.qml M +2 -2 src/contents/ui/pages/Contribute.qml M +98 -87 src/contents/ui/pages/Discover.qml M +2 -2 src/contents/ui/pages/Donate.qml M +53 -33 src/contents/ui/pages/PowerfulWhenNeeded.qml M +1 -1 src/contents/ui/pages/SimpleByDefault.qml M +26 -21 src/contents/ui/pages/Welcome.qml M +1 -1 src/qml/GenericPage.qml M +10 -0 src/qml/PlasmaFeatureButton.qml https://invent.kde.org/plasma/plasma-welcome/commit/7913b8b3eb1d57cefd3a5b2cd44f0ec20cd92236 |