| Summary: | No icons in panels for files/dirs | ||
|---|---|---|---|
| Product: | [Applications] krusader | Reporter: | Michael Konieczny <kde> |
| Component: | general | Assignee: | Krusader Bugs Distribution List <krusader-bugs-null> |
| Status: | RESOLVED DUPLICATE | ||
| Severity: | normal | CC: | krusader-bugs-null, nikita+kde, psbkde |
| Priority: | NOR | ||
| Version First Reported In: | 2.8.0 | ||
| Target Milestone: | --- | ||
| Platform: | Arch Linux | ||
| OS: | Linux | ||
| Latest Commit: | Version Fixed In: | ||
| Sentry Crash Report: | |||
| Attachments: |
No icons in panel view.
Wrong icon positioning at scale factor 1.5 Double-double spacing and artifacts from drawing |
||
Created attachment 157106 [details]
Wrong icon positioning at scale factor 1.5
According to https://forum.manjaro.org/t/no-icons-in-filelist-krusader-2-8-0-1/128019, this issue is scaling-related. I can confirm that running Krusader 2.8.0 with the following command “fixes” this issue: > QT_SCREEN_SCALE_FACTORS="eDP-1=1" krusader When running with scale factor 1.5, one can see the positioning of the icons being off, see the additional screenshot I attached. At scale factor 1.8 and above the icons disappear from view. Yet the horizontal space reserved for the icons continues to grow, there is way more space being reserved than necessary. Created attachment 157107 [details]
Double-double spacing and artifacts from drawing
For some files sometimes the horizontal offset gets doubled. And there are some artifacts, like something is drawn at borders between rows. I have scaling set to 175%.
> QT_SCREEN_SCALE_FACTORS="eDP-1=1" krusader
Works for me, but all icons get shrinked, including main toolbar, which was OK.
I could verify this to be a side-effect of https://phabricator.kde.org/D29453. The issue goes away if AA_UseHighDpiPixmaps attribute is not set. The icons are a bit blurry then but at least the file icons show up correctly. Further investigation showed that QItemDelegate will correctly consider devicePixelRatio when drawing a QIcon decoration but not when drawing a QPixmap. Krusader converts the former to the latter in order to dim icons, converting back makes the issue disappear. There are probably more glitches left however, seeing how Krusader uses icon.width() and icon.height() when it should probably be using icon.deviceIndependentSize() instead. Sorry, wrong link above. The change that caused this is actually https://invent.kde.org/utilities/krusader/-/merge_requests/36. *** This bug has been marked as a duplicate of bug 462307 *** |
Created attachment 156755 [details] No icons in panel view. After upgrade, icons disappeared. There's space for icons, but no icon, and the empty space is too wide. I've also removed krusaderrc file to start with fresh config, the same effect. Please have a look at the attached screenshot.