Bug 466250

Summary:	Some icons don't update when icon theme changes
Product:	[Applications] Welcome Center	Reporter:	ratijas <me>
Component:	general	Assignee:	Plasma Bugs List <plasma-bugs-null>
Status:	RESOLVED FIXED
Severity:	normal	CC:	kde, kdelibs-bugs-null, nate
Priority:	NOR
Version First Reported In:	unspecified
Target Milestone:	---
Platform:	Other
OS:	Linux
Latest Commit:	https://invent.kde.org/plasma/plasma-welcome/commit/3aa63aaee8371de8b87dd833daf621284ad57de3	Version Fixed/Implemented In:	5.27.2
Sentry Crash Report:
Attachments:	Plasma Welcome - some icons don't update on the fly

Description ratijas 2023-02-22 17:23:14 UTC

Created attachment 156611 [details]
Plasma Welcome - some icons don't update on the fly

SUMMARY

Noticed in the new Plasma Welcome app. Some icons adapt to icon theme changes on the fly, and some not. I found no correlation in the source code of Plasma Welcome.

STEPS TO REPRODUCE
1. Open Plasma Welcome
2. Open System Settings -> Icons KCM
3. Change icon theme.

OBSERVED RESULT
Despite all of them being Kirigami.Icon instances,
Some icons update accordingly, some — not until restart.

EXPECTED RESULT
All icons should be adaptive.

SOFTWARE/OS VERSIONS
Operating System: Arch Linux 
KDE Plasma Version: git-master
KDE Frameworks Version: git/kf5
Qt Version: 5.15.8
Kernel Version: 6.1.12-arch1-1 (64-bit)
Graphics Platform: X11
Graphics Processor: NVIDIA GeForce GTX 970M/PCIe/SSE2

ADDITIONAL INFORMATION

Doesn't seem to be related to BUG 460098 (https://bugs.kde.org/show_bug.cgi?id=460098), as starting app with different icon theme already set loads proper icons for that theme; but switching between the two themes with all icons available does not change some icons.

Comment 1 David Redondo 2023-02-23 08:48:19 UTC

The icon theme doesn't have a "systemsettings" icon, most likely because systemsettings itself uses "Icon=preferences-system" in it's desktop file. plasma-welcome should probably switch to that

Comment 2 Nate Graham 2023-02-23 14:10:57 UTC

Git commit 25161a562cc91399cd29c9f23679ea7fe79f12e7 by Nate Graham.
Committed on 23/02/2023 at 14:09.
Pushed by ngraham into branch 'master'.

Use themable icon for System Settings
FIXED-IN: 5.27.2

M  +1    -1    src/contents/ui/pages/SimpleByDefault.qml

https://invent.kde.org/plasma/plasma-welcome/commit/25161a562cc91399cd29c9f23679ea7fe79f12e7

Comment 3 Nate Graham 2023-02-23 14:19:10 UTC

Git commit 3aa63aaee8371de8b87dd833daf621284ad57de3 by Nate Graham.
Committed on 23/02/2023 at 14:18.
Pushed by ngraham into branch 'Plasma/5.27'.

Use themable icon for System Settings
FIXED-IN: 5.27.2
(cherry picked from commit 25161a562cc91399cd29c9f23679ea7fe79f12e7)

M  +1    -1    src/contents/ui/pages/SimpleByDefault.qml

https://invent.kde.org/plasma/plasma-welcome/commit/3aa63aaee8371de8b87dd833daf621284ad57de3